Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JSDoc documentation #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add JSDoc documentation #14

wants to merge 2 commits into from

Conversation

hotdang-ca
Copy link

Add JSDoc documentation to invokable methods.

@hotdang-ca
Copy link
Author

I forgot to assign this to you, @vinitshahdeo .

@vinitshahdeo vinitshahdeo self-requested a review October 11, 2019 15:57
@vinitshahdeo
Copy link
Owner

@hotdang-ca Thanks for the PR. I'll review and merge it soon.

@vinitshahdeo
Copy link
Owner

@hotdang-ca You may look into a few more good first issues here which are up for grabs!

@vinitshahdeo vinitshahdeo added the up-for-grabs Solve the issue and raise your first PR label Oct 11, 2019
@hotdang-ca
Copy link
Author

I sure will. Was there any feedback on the PR?

vinitshahdeo
vinitshahdeo reviewed Oct 11, 2019
View reviewed changes
Copy link
Owner

@vinitshahdeo vinitshahdeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hotdang-ca I've added few comments, please resolve those.

background.js Show resolved Hide resolved
background.js Show resolved Hide resolved
@hotdang-ca
Copy link
Author

hotdang-ca commented Oct 11, 2019 •
edited
Loading

Added references to API in commit cf916ac

@vinitshahdeo
Copy link
Owner

@hotdang-ca Awesome!

@hotdang-ca
Copy link
Author

Ready for Merge?

@kenanchristian kenanchristian mentioned this pull request Oct 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinitshahdeo vinitshahdeo vinitshahdeo left review comments

Assignees
No one assigned
Labels
documentation Add JSDoc good first issue Good for newcomers hacktoberfest up-for-grabs Solve the issue and raise your first PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hotdang-ca @vinitshahdeo