fix: don't list nested dirs in modules folders ci (chanzuckerberg#719)

This PR fixes a bug where modules have next folders failing CICD checks.
vincenthsh · Sep 1, 2022 · e3e6c42 · e3e6c42
1 parent 3dfc621
commit e3e6c42
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/templates/templates/.github/workflows/fogg_ci.yml.tmpl b/templates/templates/.github/workflows/fogg_ci.yml.tmpl
@@ -56,7 +56,7 @@ jobs:
             const changedFiles = {{`${{ steps.filter.outputs.changed_files }}`}}
             const changedDirs = changedFiles.map(f => path.dirname(f))
             console.log(`Found the following changed dirs: ${JSON.stringify(changedDirs, null, 2)}\n OG: ${JSON.stringify(changedFiles, null, 2)} `)
-            const changedModules = [... new Set(changedDirs.filter(d => d.indexOf("modules") !== -1))]
+            const changedModules = [... new Set(changedDirs.filter(d => d.indexOf("modules") !== -1 && d.split("/").length === 3))]
             const changedAccounts = [... new Set(changedDirs.filter(d => d.indexOf("accounts") !== -1 && d.split("/").length === 3))]
             const changedEnvs = [... new Set(changedDirs.filter(d => d.indexOf("envs") !== -1 && d.split("/").length === 4))]
             const allChanges = [...changedAccounts,...changedEnvs, ...changedModules]

diff --git a/testdata/github_actions/.github/workflows/fogg_ci.yml b/testdata/github_actions/.github/workflows/fogg_ci.yml
diff --git a/testdata/v2_full_yaml/.github/workflows/fogg_ci.yml b/testdata/v2_full_yaml/.github/workflows/fogg_ci.yml