fix: Tests broken by runatlantis#3503 (runatlantis#3583)

vincentgna · Jul 6, 2023 · b6466bd · b6466bd
1 parent 974eed3
commit b6466bd
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 19 deletions.
diff --git a/server/controllers/events/events_controller_e2e_test.go b/server/controllers/events/events_controller_e2e_test.go
@@ -901,10 +901,12 @@ func TestGitHubWorkflowWithPolicyCheck(t *testing.T) {
 			},
 		},
 		{
-			Description:   "failing policy without policies passing and custom run steps",
-			RepoDir:       "policy-checks-custom-run-steps",
-			ModifiedFiles: []string{"main.tf"},
-			ExpAutoplan:   true,
+			Description:     "failing policy without policies passing and custom run steps",
+			RepoDir:         "policy-checks-custom-run-steps",
+			ModifiedFiles:   []string{"main.tf"},
+			PolicyCheck:     true,
+			ExpAutoplan:     true,
+			ExpPolicyChecks: true,
 			Comments: []string{
 				"atlantis apply",
 			},
@@ -1160,10 +1162,10 @@ func TestGitHubWorkflowWithPolicyCheck(t *testing.T) {
 				expNumReplies--
 			}
 
-			_, _, actReplies, _ := vcsClient.VerifyWasCalled(Times(expNumReplies)).CreateComment(Any[models.Repo](), Any[int](), Any[string](), Any[string]()).GetAllCapturedArguments()
 			if !c.ExpPolicyChecks {
 				expNumReplies--
 			}
+			_, _, actReplies, _ := vcsClient.VerifyWasCalled(Times(expNumReplies)).CreateComment(Any[models.Repo](), Any[int](), Any[string](), Any[string]()).GetAllCapturedArguments()
 
 			Assert(t, len(c.ExpReplies) == len(actReplies), "missing expected replies, got %d but expected %d", len(actReplies), len(c.ExpReplies))
 			for i, expReply := range c.ExpReplies {

diff --git a/server/events/project_command_builder_internal_test.go b/server/events/project_command_builder_internal_test.go
@@ -989,9 +989,9 @@ repos:
 				},
 				Pull:               pull,
 				ProjectName:        "",
-				PlanRequirements:   []string{},
-				ApplyRequirements:  []string{},
-				ImportRequirements: []string{},
+				PlanRequirements:   []string{"policies_passed"},
+				ApplyRequirements:  []string{"policies_passed"},
+				ImportRequirements: []string{"policies_passed"},
 				RePlanCmd:          "atlantis plan -d project1 -w myworkspace -- flag",
 				RepoRelDir:         "project1",
 				User:               models.User{},
@@ -1051,13 +1051,13 @@ workflows:
 				},
 				Pull:               pull,
 				ProjectName:        "",
-				PlanRequirements:   []string{},
+				PlanRequirements:   []string{"policies_passed"},
 				ApplyRequirements:  []string{},
-				ImportRequirements: []string{},
+				ImportRequirements: []string{"policies_passed"},
 				RepoConfigVersion:  3,
 				RePlanCmd:          "atlantis plan -d project1 -w myworkspace -- flag",
 				RepoRelDir:         "project1",
-				TerraformVersion:   mustVersion("10.0"),
+				TerraformVersion:   mustVersion("v10.0"),
 				User:               models.User{},
 				Verbose:            true,
 				Workspace:          "myworkspace",
@@ -1092,10 +1092,11 @@ workflows:
 			Ok(t, os.WriteFile(globalCfgPath, []byte(c.globalCfg), 0600))
 			parser := &config.ParserValidator{}
 			globalCfgArgs := valid.GlobalCfgArgs{
-				AllowRepoCfg:  false,
-				MergeableReq:  false,
-				ApprovedReq:   false,
-				UnDivergedReq: false,
+				AllowRepoCfg:       false,
+				MergeableReq:       false,
+				ApprovedReq:        false,
+				UnDivergedReq:      false,
+				PolicyCheckEnabled: true,
 			}
 
 			globalCfg, err := parser.ParseGlobalCfg(globalCfgPath, valid.NewGlobalCfgFromArgs(globalCfgArgs))

diff --git a/server/events/project_command_builder_test.go b/server/events/project_command_builder_test.go
@@ -1398,10 +1398,11 @@ func TestDefaultProjectCommandBuilder_WithPolicyCheckEnabled_BuildAutoplanComman
 	When(vcsClient.GetModifiedFiles(Any[models.Repo](), Any[models.PullRequest]())).ThenReturn([]string{"main.tf"}, nil)
 
 	globalCfgArgs := valid.GlobalCfgArgs{
-		AllowRepoCfg:  false,
-		MergeableReq:  false,
-		ApprovedReq:   false,
-		UnDivergedReq: false,
+		AllowRepoCfg:       false,
+		MergeableReq:       false,
+		ApprovedReq:        false,
+		UnDivergedReq:      false,
+		PolicyCheckEnabled: true,
 	}
 
 	globalCfg := valid.NewGlobalCfgFromArgs(globalCfgArgs)