Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds grid_type argument to datagrid #44

Closed
wants to merge 1 commit into from

Conversation

LamAdr
Copy link
Contributor

@LamAdr LamAdr commented Nov 20, 2023

The book uses the grid_type argument. Do you want to support it?
Otherwise I can just use datagridcf directly.

@vincentarelbundock
Copy link
Owner

Yes, can you also remove the grid_type everywhere you see it in the R code and use datagridcf() instead? thanks!

@vincentarelbundock
Copy link
Owner

Meaning, I don't think we need to make this change in Python. I would rather soft deprecate this in R.

@LamAdr
Copy link
Contributor Author

LamAdr commented Nov 20, 2023

Sure. You want me to remove the grid_type references in the book only or in the R code too?

@vincentarelbundock
Copy link
Owner

Just the book.

@LamAdr LamAdr closed this Nov 20, 2023
@LamAdr LamAdr deleted the grid_type branch January 12, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants