Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variables argument to predictions #43

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

LamAdr
Copy link
Contributor

@LamAdr LamAdr commented Nov 9, 2023

Hi, this is adding support for variables argument for predictions function.

This line (111) adds the specified variables as a column to the output.

newdata.datagrid_explicit = list(variables.keys())

However, this is probably not how you want to do it ultimately. in R, all variables used in the model are present in the output, plus those specified in the variables and newdata arguments. This line will notably fail if newdata is present.

@LamAdr
Copy link
Contributor Author

LamAdr commented Nov 9, 2023

This line will notably fail if newdata is present.

I mean it will fail to add the variables as columns in the output.

@vincentarelbundock vincentarelbundock merged commit ce6c16b into vincentarelbundock:main Nov 14, 2023
1 of 2 checks passed
@vincentarelbundock
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants