fix issue #100 fixed row labels names for hypothesis= revpairwise, pairwise, revreference, reference, revsequential, sequential
#137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vincentarelbundock please, have a look and let me know if you have any comments. |
artiom-matvei
changed the title
hypothesis= revpairwise, pairwise, revreference, reference, revsequential, sequential
artiom-matvei
commented
Nov 3, 2024
tests/test_jss.py
Outdated
Comment on lines
158
to
172
| def test_hypothesis_shape_and_row_labels(h, label, impartiality_model): | ||
| for b in ["democracy", "continent"]: | ||
| c = comparisons( | ||
| impartiality_model, | ||
| by=b, | ||
| variables={"equal": [30, 90]}, | ||
| hypothesis=h, | ||
| ) | ||
| assert isinstance(c, pl.DataFrame) | ||
| if b == "democracy": | ||
| assert c.shape[0] == 1 | ||
| assert c["term"][0] == label[b] | ||
| else: | ||
| assert c.shape[0] > 1 | ||
| assert (c["term"] == label[b]).all() |
There was a problem hiding this comment.
@vincentarelbundock do you agree on testing the labels here?
|
thanks a lot for this. merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #100
Issue mentions
revpairwiseandpairwise, but this fixesrevreference,reference,revsequentialandsequentialas well.