display the correct y_label, was ignored before...

vincentarelbundock · Oct 28, 2024 · b11fd1d · b11fd1d
1 parent e291fc7
commit b11fd1d
Show file tree

Hide file tree

Showing 41 changed files with 10 additions and 7 deletions.
diff --git a/marginaleffects/comparisons.py b/marginaleffects/comparisons.py
@@ -40,7 +40,7 @@ def comparisons(
 ):
     """
     `comparisons()` and `avg_comparisons()` are functions for predicting the outcome variable at different regressor values and comparing those predictions by computing a difference, ratio, or some other function. These functions can return many quantities of interest, such as contrasts, differences, risk ratios, changes in log odds, lift, slopes, elasticities, etc.
-    
+
     Parameters
     ----------
     model : object

diff --git a/marginaleffects/p9.py b/marginaleffects/p9.py
@@ -1,13 +1,14 @@
 from plotnine import (
-    ggplot,
     aes,
+    facet_wrap,
+    facet_grid,
     geom_pointrange,
-    position_dodge,
     geom_ribbon,
     geom_line,
     geom_point,
-    facet_wrap,
-    facet_grid,
+    ggplot,
+    labs,
+    position_dodge,
 )
 import polars as pl
 
@@ -61,4 +62,6 @@ def plot_common(model, dt, y_label, var_list):
     elif len(var_list) == 4:
         p = p + facet_grid(f"{var_list[3]} ~ {var_list[2]}", scales="free")
 
+    p = p + labs(y=y_label)
+
     return p
diff --git a/tests/images/plot_comparisons/continuous_01.png b/tests/images/plot_comparisons/continuous_01.png
diff --git a/tests/images/plot_comparisons/continuous_02.png b/tests/images/plot_comparisons/continuous_02.png
diff --git a/tests/images/plot_comparisons/continuous_03.png b/tests/images/plot_comparisons/continuous_03.png
diff --git a/tests/images/plot_comparisons/discrete_01.png b/tests/images/plot_comparisons/discrete_01.png
diff --git a/tests/images/plot_comparisons/discrete_02.png b/tests/images/plot_comparisons/discrete_02.png
diff --git a/tests/images/plot_comparisons/discrete_03.png b/tests/images/plot_comparisons/discrete_03.png
diff --git a/tests/images/plot_comparisons/threenum_color.png b/tests/images/plot_comparisons/threenum_color.png
diff --git a/tests/images/plot_comparisons/threenum_horiz_axis.png b/tests/images/plot_comparisons/threenum_horiz_axis.png
diff --git a/tests/images/plot_predictions/by_01.png b/tests/images/plot_predictions/by_01.png
diff --git a/tests/images/plot_predictions/by_02.png b/tests/images/plot_predictions/by_02.png
diff --git a/tests/images/plot_predictions/condition_01.png b/tests/images/plot_predictions/condition_01.png
diff --git a/tests/images/plot_predictions/condition_02.png b/tests/images/plot_predictions/condition_02.png
diff --git a/tests/images/plot_predictions/issue_114_01.png b/tests/images/plot_predictions/issue_114_01.png
diff --git a/tests/images/plot_predictions/issue_114_02.png b/tests/images/plot_predictions/issue_114_02.png
diff --git a/tests/images/plot_predictions/issue_114_03.png b/tests/images/plot_predictions/issue_114_03.png
diff --git a/tests/images/plot_predictions/issue_114_04.png b/tests/images/plot_predictions/issue_114_04.png
diff --git a/tests/images/plot_predictions/issue_114_05.png b/tests/images/plot_predictions/issue_114_05.png
diff --git a/tests/images/plot_predictions/issue_114_06.png b/tests/images/plot_predictions/issue_114_06.png
diff --git a/tests/images/plot_predictions/issue_114_07.png b/tests/images/plot_predictions/issue_114_07.png
diff --git a/tests/images/plot_predictions/issue_114_08.png b/tests/images/plot_predictions/issue_114_08.png
diff --git a/tests/images/plot_predictions/issue_57_01.png b/tests/images/plot_predictions/issue_57_01.png
diff --git a/tests/images/plot_predictions/issue_57_02.png b/tests/images/plot_predictions/issue_57_02.png
diff --git a/tests/images/plot_predictions/issue_57_03.png b/tests/images/plot_predictions/issue_57_03.png
diff --git a/tests/images/plot_slopes/by_01.png b/tests/images/plot_slopes/by_01.png
diff --git a/tests/images/plot_slopes/by_02.png b/tests/images/plot_slopes/by_02.png
diff --git a/tests/images/plot_slopes/condition_01.png b/tests/images/plot_slopes/condition_01.png
diff --git a/tests/images/plot_slopes/condition_02.png b/tests/images/plot_slopes/condition_02.png
diff --git a/tests/images/plot_slopes/condition_03.png b/tests/images/plot_slopes/condition_03.png
diff --git a/tests/images/plot_slopes/condition_04.png b/tests/images/plot_slopes/condition_04.png
diff --git a/tests/images/plot_slopes/issue114_slopes_01.png b/tests/images/plot_slopes/issue114_slopes_01.png
diff --git a/tests/images/plot_slopes/issue114_slopes_02.png b/tests/images/plot_slopes/issue114_slopes_02.png
diff --git a/tests/images/plot_slopes/issue114_slopes_03.png b/tests/images/plot_slopes/issue114_slopes_03.png
diff --git a/tests/images/plot_slopes/issue_114_03.png b/tests/images/plot_slopes/issue_114_03.png
diff --git a/tests/images/plot_slopes/issue_114_04.png b/tests/images/plot_slopes/issue_114_04.png
diff --git a/tests/images/plot_slopes/issue_114_05.png b/tests/images/plot_slopes/issue_114_05.png
diff --git a/tests/images/plot_slopes/issue_114_06.png b/tests/images/plot_slopes/issue_114_06.png
diff --git a/tests/images/plot_slopes/issue_114_07.png b/tests/images/plot_slopes/issue_114_07.png
diff --git a/tests/images/plot_slopes/issue_114_08.png b/tests/images/plot_slopes/issue_114_08.png
diff --git a/tests/test_plot_slopes.py b/tests/test_plot_slopes.py
@@ -17,8 +17,8 @@ def test_by(self, penguins_mod_add):
         fig = plot_slopes(penguins_mod_add, variables="species", by="island")
         assert assert_image(fig, "by_01", FIGURES_FOLDER) is None
 
-        # fig = plot_slopes(mod, variables="bill_length_mm", by=["species", "island"])
-        # assert assert_image(fig, "by_02", FIGURES_FOLDER) is None
+        fig = plot_slopes(penguins_mod_add, variables="bill_length_mm", by=["species", "island"])
+        assert assert_image(fig, "by_02", FIGURES_FOLDER) is None
 
     def test_condition(self, penguins_mod_add):
         fig = plot_slopes(
-Original file line number
+Diff line change
@@ Expand Up / @@ -40,7 +40,7 @@ def comparisons( @@
     ):
         """
         `comparisons()` and `avg_comparisons()` are functions for predicting the outcome variable at different regressor values and comparing those predictions by computing a difference, ratio, or some other function. These functions can return many quantities of interest, such as contrasts, differences, risk ratios, changes in log odds, lift, slopes, elasticities, etc.
         Parameters
         ----------
         model : object
@@ Expand Down @@