Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default type is "survival" #1285

Closed
vincentarelbundock opened this issue Nov 25, 2024 · 1 comment
Closed

Default type is "survival" #1285

vincentarelbundock opened this issue Nov 25, 2024 · 1 comment

Comments

@vincentarelbundock
Copy link
Owner

Proposal: Change the priority ordering to make "survival" the default type in these model objects: clogit, coxph, flexsurv, and coxph_weightit. This would be a breaking change.

Currently, the default is "expected", which is inconsistent with the defaults in the predict() method of these packages (usually: lp).

This follows an exchange with @RobinDenz1

Tagging @ngreifer because this affects one of his models and he may have views.
vincentarelbundock added a commit that referenced this issue Dec 11, 2024
@vincentarelbundock
Issue #1285 default type for survival models
108f431
@vincentarelbundock
Copy link
Owner Author

The default type is now "survival" for models of class coxph, flexsurvreg, and coxph_weightit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vincentarelbundock