This repository has been archived by the owner on Jan 27, 2023. It is now read-only.
Fixed Issue #137 #140
Merged
Fixed Issue #137 #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also background should always be FIT_XY to be like original ImageView.
| @@ -160,6 +163,15 @@ public RoundedImageView(Context context, AttributeSet attrs, int defStyle) { | |||
| updateDrawableAttrs(); | |||
| updateBackgroundDrawableAttrs(true); | |||
|
|
|||
| if(mMutateBackground){ | |||
There was a problem hiding this comment.
nit: can you add spacing around the parens?
|
Generally looks good, just a few changes. Thanks for doing this, I've been super busy lately so it's great to have help. |
|
Looks good! Let's just remove the api checks and we're good to merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the problem with background mutation.
Also background should always be FIT_XY to be like original ImageView.