Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up VGA text mode #516

Merged
merged 3 commits into from
Jul 21, 2023
Merged

Speed up VGA text mode #516

merged 3 commits into from
Jul 21, 2023

Conversation

vinc
Copy link
Owner

@vinc vinc commented Jul 19, 2023

Scrolling was a bit slow in QEMU and a simple refactor of the new line method made it appear almost instantaneous.

Before:

> time read /tmp/alice.txt
...
Executed 'read /tmp/alice.txt' in 1.691047s

After:

> time read /tmp/alice.txt
...
Executed 'read /tmp/alice.txt' in 0.003999s

@vinc
Copy link
Owner Author

vinc commented Jul 19, 2023

This second refactor doesn't bring any measurable difference but the resulting code is smaller and clearer.

@vinc vinc marked this pull request as ready for review July 21, 2023 17:49
@vinc vinc merged commit 48dc105 into trunk Jul 21, 2023
@vinc vinc deleted the feature/vga-speedup branch July 21, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant