Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lisp cond expand #501

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Fix lisp cond expand #501

merged 2 commits into from
Jun 14, 2023

Conversation

vinc
Copy link
Owner

@vinc vinc commented Jun 13, 2023

With the following macro for eq?

(var eq?
  (macro args `(equal? ,@args)))

The macro was not expanded while expanding cond

> (cond ((equal? "a" "a") "oh noes"))
"oh noes"

> (cond ((eq? "a" "a") "oh noes"))
Error: Expected first argument to be a function

@vinc
Copy link
Owner Author

vinc commented Jun 14, 2023

There might be a more general solution during eval to expand any macros left.

@vinc vinc marked this pull request as ready for review June 14, 2023 08:06
@vinc vinc merged commit 0632631 into trunk Jun 14, 2023
@vinc vinc deleted the fix/lisp-cond-expand branch June 14, 2023 08:06
@vinc vinc mentioned this pull request Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant