Add JSON filter to upload, replace, upload_picture and upload_texttrack methods. #102
Conversation
| self.UPLOAD_ENDPOINT, | ||
| data={'type': 'streaming', | ||
| 'upgrade_to_1080': 'true' if upgrade_to_1080 else 'false'}, | ||
| params={'fields': 'upload_link,complete_uri'}) |
There was a problem hiding this comment.
It'd be preferable if these weren't passed in as defaults. The default library behavior always should be to pull everything back from a resource, and then if you want to slim down your payload, you can supply a list of the only fields you want.
Maybe an just add a new fields parameter to these upload and upload_picture methods, similar to how you did with upload_texttrack (just without hardcoding a set of base fields).
There was a problem hiding this comment.
For upload and replace I don't see the purpose of getting all the fields by default and adding a fields parameter because ticket it's not return by the method anyway, so this data can't be use.
For upload_picture and upload_texttrack I can probably change them to return everything by default (when fields=None) to keep the default library behavior but my motivation was getting the most optimize behavior by default and preventing that developers need to dig in the code to find the minimal fields needed. To keep this last goal what I propose is to return everything when fields=None and when some fields or an empty string or list is specified, the minimal fields needed will be added to the list if they're not there.
What do you think?
There was a problem hiding this comment.
Talked it over with the rest of the team, and it's okay. 👍
|
Tagged this to 0.3.10. Thanks! |
These changes will help avoid hitting the rate limit. It's possible to specified other fields wanted in
upload_pictureandupload_textrackmethods with thefieldsargument.I also made a small change that make vimeo.py compatible with python 2.6 (unfortunately I currently need this, but soon that will be move to 2.7 and 3.6 :-( ).