Fixed ignoreTypeStats & useStrictTypes flag value detection for directories in config #7182
Conversation
|
useStrictTypes is used to emulate the behavior of |
| @@ -1483,4 +1483,70 @@ public function pluginRegistersScannerAndAnalyzer(int $flags, ?int $expectedExce | |||
| self::assertSame(get_class($analyzerMock), $config->getFiletypeAnalyzers()[$extension] ?? null); | |||
| self::assertNull($expectedExceptionCode, 'Expected exception code was not thrown'); | |||
| } | |||
|
|
|||
| public function testTypeStatsForFileReporting(): void | |||
There was a problem hiding this comment.
tests are failing on windows. I'm pretty sure this has to do with path separators in getcwd()
There was a problem hiding this comment.
Sorry, I've no idea how to approach this issue. I don't have access to windows machine.
testBarebonesConfig() also uses getcwd(). I wonder how it is working.
Should I try using dirname(__DIR__, 2) instead?
There was a problem hiding this comment.
oh, that's not getcwd(), the issue is with . '/' at the end of paths. You can replace with . DIRECTORY_SEPARATOR
There was a problem hiding this comment.
Cool, it worked. Thanks.
I should be careful with dir separator from next time.
SMAtaurRahman
force-pushed
the
config-typeStats-and-strictTypes-fix
branch
from
d01a308 to
e408abf
Compare
orklah
added
the
release:fix
|
Thanks! |
I've noticed that setting any of
ignoreTypeStats="true"oruseStrictTypes="true"flag for directories in config file is ignored due to a bug inPsalm\Config\FileFilterFileFilter::loadFromXMLElement()reads these flags and turns them into boolean values, then pass the config array toFileFilter::loadFromArray(). loadFromArray reads the flag value again, but this time the function treats the values as string instead of boolean. As a result, it cannot properly detect the value.I've tried to fix the behavior with this PR.
Note: I wasn't able to understand the purpose of
useStrictTypes=true. Can you please let me know what difference does it make?