Convertion of partials to full imports #7155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess the error is related to #7153?! |
weirdan
added
the
release:internal
weirdan
reviewed
Dec 14, 2021
| @@ -1124,7 +1136,7 @@ public function getSymbolLocation(string $file_path, string $symbol): ?CodeLocat | |||
|
|
|||
| $file_contents = $this->getFileContents($file_path); | |||
|
|
|||
| return new CodeLocation\Raw( | |||
| return new Raw( | |||
There was a problem hiding this comment.
This is an example of where readability does suffer. Could be renamed to RawLocation though.
There was a problem hiding this comment.
Yep, Raw is quite inexpressively.
The good thing is, it is used only 4 times. Anyway, DocblockTypeLocation and ParseErrorLocation are postfixed, so this should really be RawLocation.
But I think this should go into an extra PR.
There was a problem hiding this comment.
But I think this should go into an extra PR.
Of course.
|
I'm halfway through the review, and this is actually not too bad. |
weirdan
approved these changes
Dec 14, 2021
Those two should probably also be added to that list: |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finally have converted "all" partial to full imports.
I was looking at all cases but I don’t think readability suffers at any case, as mostly they are unambiguous due prefixing or postfixing or just by naming or context.
One exception is the
PhpParsernamespace which will need an extra issue for discussion and so is left out here.