added mysqli::connect() to callmap #6805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orklah
added
the
release:fix
weirdan
requested changes
Nov 3, 2021
dictionaries/CallMap_81_delta.php
Outdated
| @@ -627,6 +627,10 @@ | |||
| 'old' => ['bool', 'ldap'=>'resource', 'callback'=>'string'], | |||
| 'new' => ['bool', 'ldap'=>'LDAP\Connection', 'callback'=>'string'], | |||
| ], | |||
| 'mysqli::connect' => [ | |||
| 'old' => ['null|false', 'hostname='=>'string', 'username='=>'string', 'password='=>'string', 'database='=>'string', 'port='=>'int', 'socket='=>'string'], | |||
| 'new' => ['bool', 'hostname='=>'string', 'username='=>'string', 'password='=>'string', 'database='=>'string', 'port='=>'int', 'socket='=>'string'], | |||
There was a problem hiding this comment.
Starting with PHP 8 all parameters are nullable:
$ php -v
PHP 8.0.7 (cli) (built: Aug 1 2021 01:14:34) ( NTS )
Copyright (c) The PHP Group
Zend Engine v4.0.7, Copyright (c) Zend Technologies
with Zend OPcache v8.0.7, Copyright (c), by Zend Technologies
with Xdebug v3.0.4, Copyright (c) 2002-2021, by Derick Rethans
$ php --rf 'mysqli::connect'
Method [ <internal:mysqli> public method connect ] {
- Parameters [6] {
Parameter #0 [ <optional> ?string $hostname = null ]
Parameter #1 [ <optional> ?string $username = null ]
Parameter #2 [ <optional> ?string $password = null ]
Parameter #3 [ <optional> ?string $database = null ]
Parameter #4 [ <optional> ?int $port = null ]
Parameter #5 [ <optional> ?string $socket = null ]
}
}There was a problem hiding this comment.
Before that, they were just optional.
There was a problem hiding this comment.
Great find. TIL about php --rf argument. I think its time to read man php properly. Thanks for the knowledge.
I've updated mysqli::__construct too, since they are almost same.
I guess I should submit a PR to PHP-doc repo now to reflect this change.
weirdan
approved these changes
Nov 3, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds mysqli::connect() function signature to callmap including its change of return value in PHP 8.1
Fixes #6406