Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Require ext-ctype #6368

Merged
merged 1 commit into from
Aug 27, 2021
Merged

Fix: Require ext-ctype #6368

merged 1 commit into from
Aug 27, 2021

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Aug 27, 2021

This pull request

  • explicitly requires the implicitly required ext-ctype

Spotted in sebastianbergmann/phpunit#4759.

πŸ’β€β™‚οΈ Running

$ git grep ctype_

yields (among others)

src/Psalm/Internal/Codebase/ConstantTypeResolver.php:9:use function ctype_digit;
src/Psalm/Internal/Codebase/ConstantTypeResolver.php:202:                    } elseif (ctype_digit($key_type->value)) {

❗ You might be interested in taking a look at shivammathur/setup-php#487, where @shivammathur has already put capabilities in place that allow disabling all PHP extensions, and enabling those that are required. This allows detecting hidden dependencies on PHP extensions.

@weirdan weirdan merged commit b4f4c94 into vimeo:master Aug 27, 2021
@weirdan
Copy link
Collaborator

weirdan commented Aug 27, 2021

Thanks!

@localheinz localheinz deleted the fix/ctype branch August 27, 2021 13:46
@localheinz
Copy link
Contributor Author

Thank you, @weirdan!

@drupol
Copy link
Contributor

drupol commented Aug 27, 2021

There's also this tool which can be useful: https://github.com/maglnet/ComposerRequireChecker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants