Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider print, and conditionally exit / die impure #6188

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Consider print, and conditionally exit / die impure #6188

merged 1 commit into from
Jul 27, 2021

Conversation

Jack97
Copy link
Contributor

@Jack97 Jack97 commented Jul 27, 2021

I've updated the PrintAnalyzer to raise an ImpureFunctionCall issue in a mutation-free context.

I've updated the ExitAnalyzer to do the same thing, but only when a non-integer argument is provided.

Closes #6136

@weirdan weirdan merged commit 813e375 into vimeo:master Jul 27, 2021
@weirdan
Copy link
Collaborator

weirdan commented Jul 27, 2021

Thanks!

@kkmuffme kkmuffme mentioned this pull request Feb 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

print, exit, and die effect IO but they are considered pure.
2 participants
@Jack97 @weirdan