Update mbstring signatures for PHP 8

[mpesari]

Fixes #3287

I went through the mb_* functions which had return value specified as something|false in the CallMap.php, and compared them to current documentation at https://php.net

Here is the summary of functions changed in PHP 8 and links to src and/or tests:

mb_convert_case()

• https://github.com/php/php-src/blob/php-7.4.20/ext/mbstring/mbstring.c#L3436
• https://github.com/php/php-src/blob/php-8.0.7/ext/mbstring/mbstring.c#L2583
• https://github.com/php/php-src/blob/php-7.4.20/ext/mbstring/tests/mb_convert_case_invalid_mode.phpt
• https://github.com/php/php-src/blob/php-8.0.7/ext/mbstring/tests/mb_convert_case_various_mode.phpt

mb_convert_kana()

• https://github.com/php/php-src/blob/php-7.4.20/ext/mbstring/mbstring.c#L3753
• https://github.com/php/php-src/blob/php-8.0.7/ext/mbstring/mbstring.c#L2859

mb_decode_numericentity()

• https://github.com/php/php-src/blob/php-7.4.20/ext/mbstring/mbstring.c#L4146
• https://github.com/php/php-src/blob/php-8.0.7/ext/mbstring/mbstring.c#L3227

mb_encode_mimeheader()

• https://github.com/php/php-src/blob/php-7.4.20/ext/mbstring/mbstring.c#L3670
• https://github.com/php/php-src/blob/php-8.0.7/ext/mbstring/mbstring.c#L2780

mb_encode_numericentity()

• https://github.com/php/php-src/blob/php-7.4.20/ext/mbstring/mbstring.c#L4138
• https://github.com/php/php-src/blob/php-8.0.7/ext/mbstring/mbstring.c#L2780

mb_scrub()

• https://github.com/php/php-src/blob/php-7.4.20/ext/mbstring/mbstring.c#L5173
• https://github.com/php/php-src/blob/php-8.0.7/ext/mbstring/mbstring.c#L4186

mb_strimwidth()

• https://github.com/php/php-src/blob/php-7.4.20/ext/mbstring/mbstring.c#L3087
• https://github.com/php/php-src/blob/php-8.0.7/ext/mbstring/mbstring.c#L2274
• https://github.com/php/php-src/blob/php-7.4.20/ext/mbstring/tests/mb_strimwidth.phpt
• https://github.com/php/php-src/blob/php-8.0.7/ext/mbstring/tests/mb_strimwidth.phpt

mb_strlen()

• https://github.com/php/php-src/blob/php-7.4.20/ext/mbstring/mbstring.c#L3087
• https://github.com/php/php-src/blob/php-8.0.7/ext/mbstring/mbstring.c#L2274

mb_strtolower()

• https://github.com/php/php-src/blob/php-7.4.20/ext/mbstring/mbstring.c#L3509
• https://github.com/php/php-src/blob/php-8.0.7/ext/mbstring/mbstring.c#L2646
• https://github.com/php/php-src/blob/php-7.4.20/ext/mbstring/tests/mb_strtoupper_error2.phpt
• https://github.com/php/php-src/blob/php-8.0.7/ext/mbstring/tests/mb_strtolower_error2.phpt

mb_strtoupper()

• https://github.com/php/php-src/blob/php-7.4.20/ext/mbstring/mbstring.c#L3475
• https://github.com/php/php-src/blob/php-8.0.7/ext/mbstring/mbstring.c#L2618
• https://github.com/php/php-src/blob/php-7.4.20/ext/mbstring/tests/mb_strtoupper_error2.phpt
• https://github.com/php/php-src/blob/php-8.0.7/ext/mbstring/tests/mb_strtoupper_error2.phpt

mb_strwidth()

• https://github.com/php/php-src/blob/php-7.4.20/ext/mbstring/mbstring.c#L3060
• https://github.com/php/php-src/blob/php-8.0.7/ext/mbstring/mbstring.c#L2249

mb_substr_count()

• https://github.com/php/php-src/blob/php-7.4.20/ext/mbstring/mbstring.c#L2899
• https://github.com/php/php-src/blob/php-8.0.7/ext/mbstring/mbstring.c#L2086
• https://github.com/php/php-src/blob/php-7.4.20/ext/mbstring/tests/mb_substr_count_error2.phpt
• https://github.com/php/php-src/blob/php-8.0.7/ext/mbstring/tests/mb_substr_count_error2.phpt

mb_substr()

• https://github.com/php/php-src/blob/php-7.4.20/ext/mbstring/mbstring.c#L2931
• https://github.com/php/php-src/blob/php-8.0.7/ext/mbstring/mbstring.c#L2123
• https://github.com/php/php-src/blob/php-7.4.20/ext/mbstring/tests/mb_substr_error2.phpt
• https://github.com/php/php-src/blob/php-8.0.7/ext/mbstring/tests/mb_substr_error2.phpt

[mpesari]

Actually, I'm not sure what to about mb_decode_numericentity. If you look closely, the CallMap.php line had the 'is_hex' parameter, while the CallMap_80_delta.php's $new array didn't, and the $old array did have it. So.. not sure about the relation between

a) the line in CallMap.php,
b) the line in CallMap_80_delta.php's $new array, and
c) the line in CallMap_80_delta.php's $old array

Where should the (unused) 'is_hex' parameter be?

https://www.php.net/manual/en/function.mb-decode-numericentity.php

[weirdan]

Where should the (unused) 'is_hex' parameter be?

It was removed in PHP 8.0 (see Changelog). So it should not be present in CallMap and in 80_delta/$new, but it should be in 80_delta/$old

[weirdan]

Thanks!