Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop FakeFileProvider from tests folder #6030

Merged

Conversation

weirdan
Copy link
Collaborator

@weirdan weirdan commented Jul 1, 2021

And use Psalm\Internal\Provider\FakeFileProvider

Part 2 of #6029

@weirdan
Copy link
Collaborator Author

weirdan commented Jul 1, 2021

CI failures on master and in this PR are caused by the fix to PHP bug #81070 (commit).

weirdan added a commit to weirdan/psalm that referenced this pull request Jul 2, 2021

Verified

This commit was signed with the committer’s verified signature.
neunhoef Max Neunhöffer
This addresses vimeo#6030 (comment)

Previously PHP would allow to set memory limit to be below current
memory usage, and the test changed in this PR abused that. As we
actually don't need to test `ini_get()` value decoding was split into
its own method, and we're testing that decoding instead.
And use Psalm\Internal\Provider\FakeFileProvider
@weirdan weirdan force-pushed the drop-FakeFileProvider-from-tests-folder branch from 9d2f840 to 76be96c Compare July 2, 2021 00:58
@weirdan weirdan merged commit dfe31c6 into vimeo:master Jul 3, 2021
@weirdan weirdan deleted the drop-FakeFileProvider-from-tests-folder branch July 3, 2021 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant