Don't attempt to read baseline before it was generated

[weirdan]

Fixes #5960

Previous fix would not return generated baseline.

[muglug]

Sorry, mind running through what steps weren't happening before that are now?

[weirdan]

4.7.3 would write baseline, read it back and then use in IssueBuffer::finish(). I'm checking whether that was actually required.

[weirdan]

@muglug this prevents a cosmetic issue where issues added to the baseline during current run are still reported:

[muglug]

Thanks! Not sufficient for a separate release, but this is great.

[orklah]

@weirdan This cosmetic issue is exactly what I was trying to achieve in #5838 after discussing it in #5831 :)

When running with a baseline, it become impossible to know what issues have been added

On our project, Psalm takes too long to run to hope adding it in CI, so we have a setup that runs Psalm regularly and saves the errors in baseline. Each time we see new errors, we handle them and report to whoever may be concerned.

Without this, we need to run Psalm once without baseline, takes the issues and send them, then re-run Psalm with the baseline.

Can we revert this change or introduce a new option to return to the described behaviour?

[weirdan]

On our project, Psalm takes too long to run to hope adding it in CI

Even with cache enabled?

[weirdan]

@orklah and I thought I botched that during refactoring, because I was comparing with last good release (4.7.3) 😆

Obligatory xkcd:1172.

In that workflow of yours, do you output machine-readable data (e.g. --output-format/--report)?

[orklah]

Even with cache enabled?

Trying to run Psalm without --no-cache brings the whole server down in about 15-20 minutes (a run without cache takes 10 minutes). I never could go to the bottom of this issue (I still hope I will one day !)

Obligatory xkcd:1172.

😄

In that workflow of yours, do you output machine-readable data (e.g. --output-format/--report)?

I don't remember the option we use, but we also retrieve in a file the whole list of issues reported by Psalm but the baseline is ignored when doing that so we retrieve every issue