allow dismissing return value of no-return pure functions #5461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And you want to keep such functions pure to be able to call them in pure contexts, right? |
|
yes, example:
currently to avoid this i suppressed all UnusedFunctionCall ( https://github.com/azjezz/psl/blob/1.6.x/psalm.xml#L65 ), but i don't really want to do that also relevant: also relevant: azjezz/psl#163 (comment) |
|
build failure is unrelated. |
|
I think this is exactly the right approach, thanks! While traditionally throwing an exception might be considered a side-effect, I think Psalm's notion of purity is safe enough |
muglug
reviewed
Mar 23, 2021
| !( | ||
| $function_call_info->function_storage && | ||
| $function_call_info->function_storage->return_type && | ||
| (array_values($function_call_info->function_storage->return_type->getAtomicTypes())[0] ?? null) instanceof Type\Atomic\TNever |
There was a problem hiding this comment.
I replaced this with $function_call_info->function_storage->return_type->isNever()
There was a problem hiding this comment.
i didn't notice the method existed 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs azjezz/psl#163
no-return function either:
in all of these cases, it's okay not to use the return value.