Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve @no-named-arguments support and variadics. #5455

Merged
merged 2 commits into from
Mar 22, 2021

Conversation

AndrolGenhald
Copy link
Collaborator

@AndrolGenhald AndrolGenhald commented Mar 22, 2021

Handling of argument unpacking and variadics still needs a pretty big makeover, but this is a good start.

Fixes #5420
Improves #5453 (iterable works, array still causes issues)
Fixes #5454

Handling of argument unpacking and variadics still needs a pretty big makeover, but this is a good start.

Fixes vimeo#5420
Improves vimeo#5453 (iterable works, array still causes issues)
@AndrolGenhald
Copy link
Collaborator Author

I branched from 9f3f420^ and the tests ran fine locally (though some where skipped).

@muglug muglug merged commit de5a031 into vimeo:master Mar 22, 2021
@muglug
Copy link
Collaborator

muglug commented Mar 22, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent argument unpacking iterable with non-array-key key Variadic parameters and list type
2 participants