Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow session_name to also return false #4855

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Allow session_name to also return false #4855

merged 1 commit into from
Dec 17, 2020

Conversation

christeredvartsen
Copy link
Contributor

According to the PHP docs the session_name signature is:

session_name ([ string|null $name = null ] ) : string|false

Resolves Possibly incorrect handling of session_name() #4854.

session_name ([ string|null $name = null ] ) : string|false

Resolves Possibly incorrect handling of session_name() #4854
@weirdan
Copy link
Collaborator

weirdan commented Dec 17, 2020

@muglug muglug closed this Dec 17, 2020
@muglug muglug reopened this Dec 17, 2020
@muglug muglug merged commit 2a4e5a2 into vimeo:master Dec 17, 2020
@muglug
Copy link
Collaborator

muglug commented Dec 17, 2020

Thanks!

danog pushed a commit to danog/psalm that referenced this pull request Jan 29, 2021
session_name ([ string|null $name = null ] ) : string|false

Resolves Possibly incorrect handling of session_name() vimeo#4854
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants