Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to amp v3 #10024

Merged
merged 13 commits into from
Jul 28, 2023
Merged

Switch to amp v3 #10024

merged 13 commits into from
Jul 28, 2023

Conversation

danog
Copy link
Collaborator

@danog danog commented Jul 19, 2023

No description provided.

@danog danog mentioned this pull request Jul 19, 2023
@weirdan
Copy link
Collaborator

weirdan commented Jul 21, 2023

Is this something for Psalm 6?

@danog
Copy link
Collaborator Author

danog commented Jul 21, 2023

Yep, it seems like it, since we're raising the minimum version

@danog
Copy link
Collaborator Author

danog commented Jul 24, 2023

@orklah Do you think you could make another branch for v5 just like we did for v4?
I don't have any clear ETA for v6, but at least this way people that have dependency conflicts due to amp will be able to require the dev-master branch, instead (and I could also send in some PRs to remove stuff that was planned for deprecation in v6).

@danog
Copy link
Collaborator Author

danog commented Jul 24, 2023

Addendum: I don't have any clear date for v6 in mind, but I would prefer we avoid prolonging the release like we did last time, it's no big deal to make majors once or twice a year IMO :)

@danog danog added the release:internal The PR will be included in 'Internal changes' section of the release notes label Jul 24, 2023
@danog danog marked this pull request as ready for review July 24, 2023 08:02
@danog danog added this to the Psalm 6 milestone Jul 25, 2023
@danog
Copy link
Collaborator Author

danog commented Jul 26, 2023

Should be good to merge!

@weirdan weirdan merged commit cccec81 into vimeo:master Jul 28, 2023
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:internal The PR will be included in 'Internal changes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants