Report usage of depreacted properties

[bdsl]

In a large class or a class with widely used public properties it may be difficult to immediately delete an unwanted property, and preferable to deprecate it.

I would like Psalm to report usages of deprecated properties, as at

https://psalm.dev/r/34c8584df8

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/34c8584df8

<?php

class Foo
{
    /**
      * @deprecated
      * @var int
      */
    private $bar = 0;
    
    public function bar(): int
    {
        return $this->bar;
    }
      
}

Psalm output (using commit f015c30):

No issues!

[weirdan]

Actually Psalm reports deprecated properties when they are accessed from outside of the class. I don't see a reason why we shouldn't report when accessed from the class scope.

[weirdan]

Moreover, we already report property writes: https://psalm.dev/r/66aa00201a

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/66aa00201a

<?php

class Foo
{
    /**
      * @deprecated
      * @var int
      */
    public $bar = 0;
    
    public function bar(int $p): void
    {
        $this->bar = $p;
    }
      
}

Psalm output (using commit f015c30):

ERROR: DeprecatedProperty - 13:9 - Foo::$bar is marked deprecated