Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PossiblyUnusedReturnValue false-positive with throw #5975

Closed
enumag opened this issue Jun 22, 2021 · 1 comment · Fixed by #5989
Closed

PossiblyUnusedReturnValue false-positive with throw #5975

enumag opened this issue Jun 22, 2021 · 1 comment · Fixed by #5989
Assignees
@weirdan
Labels
bug control flow

Comments

@enumag
Copy link
Contributor

enumag commented Jun 22, 2021

https://psalm.dev/r/844d55abf9
@psalm-github-bot
Copy link

I found these snippets:

https://psalm.dev/r/844d55abf9 
<?php

class A {
    public function foo() : Exception {
        return new Exception;
    }
}
throw (new A)->foo();
Psalm output (using commit 6d4d166):

ERROR: PossiblyUnusedReturnValue - 4:29 - The return value for this method is never used

@weirdan weirdan self-assigned this Jun 23, 2021
weirdan added a commit to weirdan/psalm that referenced this issue Jun 23, 2021
@weirdan
Mark return values in as throw argument as used
b191286 
Fixes vimeo#5975
@weirdan weirdan mentioned this issue Jun 23, 2021
Merged
muglug pushed a commit that referenced this issue Jun 25, 2021
@weirdan
Mark return values in as throw argument as used (#5989)
6d4262e 
Fixes #5975
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weirdan weirdan

Labels
bug control flow
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mark return values in throw arguments as used weirdan/psalm
2 participants
@weirdan @enumag