Psalm is sometimes inferring the wrong type for no reason.

[VincentLanglet]

Hi @muglug

I didn't succeed reproducing the issue in psalm.dev. But I have an open PR with commits about the issue:
sonata-project/SonataAdminBundle#6713

In this PR:

public function getNewInstance()
{
    $object = $this->getModelManager()->getModelInstance($this->getClass());

    $this->appendParentObject($object);

    foreach ($this->getExtensions() as $extension) {
        $extension->alterNewInstance($this, $object);
    }

    return $object;
}

Is reported as returning an object instead of the template T.

I find out that commenting

$this->appendParentObject($object);

fix the issue.

Then I find out that changing

/**
 * @phpstan-param T $object
 */
final protected function appendParentObject(object $object): void

to

/**
 * @phpstan-param T $object
 */
final protected function appendParentObject($object): void

fix the issue.

I think that psalm shouldn't report anything.
What is more weird, is that it's reporting an issue in the commit
sonata-project/SonataAdminBundle@1c08c17
but not in the previous commit
sonata-project/SonataAdminBundle@3091807

[muglug]

Is this still the case on latest master?

[VincentLanglet]

Yes, it is @muglug : sonata-project/SonataAdminBundle@1a8fa93

[VincentLanglet]

The issue was on me.