Fix negative numbers

vimeo · Jul 8, 2021 · f545bf9 · f545bf9
1 parent bbbfa69
commit f545bf9
Show file tree

Hide file tree

Showing 3 changed files with 41 additions and 0 deletions.
diff --git a/src/Psalm/Internal/Type/TypeTokenizer.php b/src/Psalm/Internal/Type/TypeTokenizer.php
@@ -384,6 +384,10 @@ public static function getFullyQualifiedTokens(
                 continue;
             }
 
+            if ($string_type_token[0][0] === '-' && is_numeric($string_type_token[0])) {
+                continue;
+            }
+
             if (isset($type_tokens[$i + 1])
                 && $type_tokens[$i + 1][0] === ':'
                 && isset($type_tokens[$i - 1])

diff --git a/tests/MagicMethodAnnotationTest.php b/tests/MagicMethodAnnotationTest.php
@@ -703,6 +703,34 @@ public function __call($method, $attributes)
                         (new \Foo\G)->randomInt();
                     }'
             ],
+            'negativeInDefault' => [
+                '<?php
+                    /**
+                     * @method void takesFloat($a = -0.1, $b = -1)
+                     */
+                    class G
+                    {
+                        public function __call(string $method, array $attributes): void
+                        {
+                        }
+                    }
+                    (new G)->takesFloat();'
+            ],
+            'namespacedNegativeInDefault' => [
+                '<?php
+                    namespace Foo {
+                        /**
+                         * @method void takesFloat($a = -0.1, $b = -1)
+                         */
+                        class G
+                        {
+                            public function __call(string $method, array $attributes): void
+                            {
+                            }
+                        }
+                        (new G)->takesFloat();
+                    }'
+            ],
             'namespacedUnion' => [
                 '<?php
                     namespace Foo;

diff --git a/tests/TypeReconciliation/ValueTest.php b/tests/TypeReconciliation/ValueTest.php
@@ -607,6 +607,15 @@ class A {
                         private $type = "easy";
                     }'
             ],
+            'supportMultipleValues' => [
+                '<?php
+                    class A {
+                        /**
+                         * @var 0|-1|1
+                         */
+                        private $type = -1;
+                    }'
+            ],
             'typecastTrueToInt' => [
                 '<?php
                 /**