Make Algebra::negateFormula a little more safe

vimeo · Apr 13, 2020 · d470903 · d470903
1 parent a25610c
commit d470903
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/src/Psalm/Type/Algebra.php b/src/Psalm/Type/Algebra.php
@@ -546,7 +546,7 @@ function ($possible_type) {
     }
 
     /**
-     * @param  array<int, Clause>  $clauses
+     * @param  non-empty-array<int, Clause>  $clauses
      *
      * @return array<int, Clause>
      */
@@ -759,11 +759,21 @@ public static function combineOredClauses(array $left_clauses, array $right_clau
      */
     public static function negateFormula(array $clauses)
     {
+        if (!$clauses) {
+            return [new Clause([], true)];
+        }
+
         foreach ($clauses as $clause) {
             self::calculateNegation($clause);
         }
 
-        $negated = self::simplifyCNF(self::groupImpossibilities($clauses));
+        $impossible_clauses = self::groupImpossibilities($clauses);
+
+        if (!$impossible_clauses) {
+            return [new Clause([], true)];
+        }
+
+        $negated = self::simplifyCNF($impossible_clauses);
 
         if (!$negated) {
             return [new Clause([], true)];