Fix #4017 - allow float defaults in namespaced classes

vimeo · Aug 18, 2020 · 45d9ab1 · 45d9ab1
1 parent ebe3739
commit 45d9ab1
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 2 deletions.
diff --git a/src/Psalm/Internal/Type/TypeTokenizer.php b/src/Psalm/Internal/Type/TypeTokenizer.php
@@ -361,8 +361,7 @@ public static function getFullyQualifiedTokens(
 
             if ($string_type_token[0][0] === '"'
                 || $string_type_token[0][0] === '\''
-                || $string_type_token[0] === '0'
-                || preg_match('/[1-9]/', $string_type_token[0][0])
+                || preg_match('/[0-9]/', $string_type_token[0][0])
             ) {
                 continue;
             }

diff --git a/tests/MagicMethodAnnotationTest.php b/tests/MagicMethodAnnotationTest.php
@@ -668,6 +668,32 @@ public function __construct(\IteratorAggregate $foos)
                         }
                     }'
             ],
+            'parseFloatInDefault' => [
+                '<?php
+                    namespace Foo {
+                        /**
+                         * @method int randomInt()
+                         * @method void takesFloat($a = 0.1)
+                         */
+                        class G
+                        {
+                            /**
+                             * @param string $method
+                             * @param array $attributes
+                             *
+                             * @return mixed
+                             */
+                            public function __call($method, $attributes)
+                            {
+                                return null;
+                            }
+                        }
+                    }
+
+                    namespace Bar {
+                        (new \Foo\G)->randomInt();
+                    }'
+            ],
         ];
     }