This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliewongbandue
previously approved these changes
Mar 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small nits, otherwise, lgtm.
juliewongbandue
approved these changes
Mar 10, 2023
Gonna tag @tylerthegrove for a second pair of eyes since this will be the first time we'll be including a third party dependency since they were first removed. 👀 |
tylerthegrove
suggested changes
Mar 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once we verify that the new dependency isn't included in rollup, I'm good with this.
juliewongbandue
requested review from
tylerthegrove
and removed request for
tylerthegrove
March 15, 2023 20:33
tylerthegrove
approved these changes
Mar 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds
ColorSelect2
component which is a new version that eventually will replaceColorSelect
.The biggest change is in the spectrum and hue implementation to use react-colorful package that has better functionality and tests.
Currently is
ColorSelect
there's a critical bug where users cannot select colors from the edges, so black/white cannot be reached -ColorSelect2
is fixing it.This PR merge is blocked by merging #235, after that merge the only changes between this PR and master will be under
ColorSelect2
folder.Important Changes
2 Tests are failing for
ColorSelect2
.I've commented them out for now, I don't think it's a blocker because it's v2 and most teams can move the v2 without these props.
required
was used to add an attribute to a div, to be honest I'm not sure why we would want to addrequired
to a div.name
was also added to the same div, also not sure why we would do it.Screenshots & Recordings
New.Recording.-.3_10_2023.8_47_21.AM.mp4
How it does that
react-colorful
and change a bit the css to fit the propsColorSelect
is providingTesting
Unit tests from original
ColorSelect
are used.All stories have been copied to have both
ColorSelect
andColorSelect2