Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sorting of plugins with dependencies #317

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

domekomi
Copy link

Fix a problem that a plugin with deep dependencies is not sorted properly. This PR also add features to detect errors of circular dependencies and missing plugins.

@tyru
Copy link
Member

tyru commented Mar 25, 2020

Sorry for late reply.
Could you show me the examples?

  • deep dependencies is not sorted properly
  • circular dependencies
  • missing plugins

@domekomi
Copy link
Author

deep dependencies is not sorted properly

If a plugin A depends on B and B doesn't depends on other plugins (A -> B), these plugins are sorted properly. However, if B depends on C (A -> B -> C), not sorted properly.

circular dependencies

e.g. A depends on B and B depends on A (A -> B -> A).

missing plugins

e.g. A depends on B, but B is not found.

@tyru
Copy link
Member

tyru commented Jan 31, 2022

Should be related #333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants