Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Test only the nearest two major go versions #293

Merged
merged 3 commits into from
May 26, 2019
Merged

Conversation

tyru
Copy link
Member

@tyru tyru commented May 26, 2019

On the latest go command appends go 1.13 at the bottom of go.mod.

https://travis-ci.org/vim-volt/volt/jobs/537348218

$ go version
go version devel +d97bd5d07a Sat May 25 22:38:01 2019 +0000 linux/amd64

This PR avoids that.

@tyru tyru changed the title Fix travis fail on go tip (go version devel +d97bd5d07a) [CI] Test only the nearest two major go versions May 26, 2019
@tyru
Copy link
Member Author

tyru commented May 26, 2019

As of go 1.12, go command appends language version if missing (ref.: golang/go@48b7bdd0d7)

https://golang.org/doc/go1.12#modules

The go directive in a go.mod file now indicates the version of the language used by the files within that module. It will be set to the current release (go 1.12) if no existing version is present. If the go directive for a module specifies a version newer than the toolchain in use, the go command will attempt to build the packages regardless, and will note the mismatch only if that build fails.


It is hard to track go tip, and Volt doesn't need to. it is enough to test only the nearest two major go versions

@tyru tyru merged commit 885e22b into devel May 26, 2019
@tyru tyru deleted the fix-travis-fail branch May 26, 2019 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant