Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort entries in lockJSON #284

Merged
merged 1 commit into from
May 3, 2019
Merged

Sort entries in lockJSON #284

merged 1 commit into from
May 3, 2019

Conversation

hupfdule
Copy link
Contributor

@hupfdule hupfdule changed the base branch from master to devel April 29, 2019 13:14
subcmd/get.go Show resolved Hide resolved
@tyru
Copy link
Member

tyru commented May 3, 2019

I think there are no problems except above points.
Really thanks for the continuous contribution!

@tyru
Copy link
Member

tyru commented May 3, 2019

After one day passed, a thought came across my mind that lock.json always be consistent in any command, not only volt get command.
So now I think it is OK to sort entries in lockJson.Write().

Sorry for confusions, I haven't spent reading volt code these days... 😭
I'll make a pull request for that fix after merging your commits.
Please wait a moment.

@tyru tyru merged commit c87d196 into vim-volt:devel May 3, 2019
@tyru
Copy link
Member

tyru commented May 3, 2019

Merged by #287

tyru added a commit to tyru/config that referenced this pull request Jun 6, 2019
... to sort arrays in lock.json
vim-volt/volt#284
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants