Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[volt get -u] Don't change 'repos/trx_id' if no other properties are changed #149

Closed
tyru opened this issue Dec 27, 2017 · 5 comments
Closed

Comments

@tyru
Copy link
Member

tyru commented Dec 27, 2017

No description provided.

@last-partizan
Copy link
Contributor

Would be great to see this implemented.

It will make storing lockfile in git and syncing better. Any plans for this one?

Looks like this is simple enough issue, maybe i'll try to fix it. However it'll take a time, i have no expirience with go beyond tutorial.

@tyru
Copy link
Member Author

tyru commented Mar 15, 2018

Contribution is welcome!
Currently I'm not planning to fix this issue soon, because this is not so annoying for me :p
That's great if you could help fixing this :)

@last-partizan
Copy link
Contributor

Nice!
May i ask, why there is need to store that trx_id at all? other package managers, like yarn, don't store anything like that.

@tyru
Copy link
Member Author

tyru commented Mar 15, 2018

Well, at first, that property is added because vim-volt plugin can detect which plugins are installed/updated.
After that, vim-volt plugin reloads installed/updated plugins to take effect in current Vim, without restarting Vim.

But now, trx_id and repos[].trx_id are indeed not necessary.
It is for vim-volt plugin, but the plugin can detect it without trx_id, such as saving previous hashes and checking updated hashes, and added plugins.

@last-partizan
Copy link
Contributor

Great!
I'll take a look.

last-partizan added a commit to last-partizan/volt that referenced this issue Mar 15, 2018
last-partizan added a commit to last-partizan/volt that referenced this issue Mar 17, 2018
tyru added a commit that referenced this issue Mar 17, 2018
@tyru tyru closed this as completed Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants