Skip to content

Commit

Permalink
destructive: don't clone submodules recursively
Browse files Browse the repository at this point in the history
* Don't clone submodules recursively temporarily. (ref. #187)
* Change default value of get.fallback_git_cmd (ref. #193)
  • Loading branch information
tyru committed Apr 21, 2018
1 parent 9c4bfce commit b24f2df
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
3 changes: 2 additions & 1 deletion config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,14 @@ const (

func initialConfigTOML() *Config {
trueValue := true
falseValue := false
return &Config{
Build: configBuild{
Strategy: SymlinkBuilder,
},
Get: configGet{
CreateSkeletonPlugconf: &trueValue,
FallbackGitCmd: &trueValue,
FallbackGitCmd: &falseValue,
},
}
}
Expand Down
7 changes: 5 additions & 2 deletions subcmd/get.go
Original file line number Diff line number Diff line change
Expand Up @@ -625,8 +625,11 @@ func (cmd *getCmd) gitPull(r *git.Repository, workDir string, remote string, cfg
return err
}
err = wt.Pull(&git.PullOptions{
RemoteName: remote,
RecurseSubmodules: 10,
RemoteName: remote,
// TODO: Temporarily recursive clone is disabled, because go-git does
// not support relative submodule url in .gitmodules and it causes an
// error
RecurseSubmodules: 0,
})
if err == nil || err == git.NoErrAlreadyUpToDate {
return err
Expand Down

0 comments on commit b24f2df

Please sign in to comment.