Fix warnings: override is needed #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4513ECHO
reviewed
Sep 24, 2024
| @@ -27,7 +27,7 @@ export class Source extends BaseSource<Params> { | |||
| return inputLength - preEditLength; | |||
| } | |||
|
|
|||
| async gather( | |||
| override async gather( | |||
There was a problem hiding this comment.
For abstract method override keyword is not necessary. Please see microsoft/TypeScript#47250 for the reason.
Suggested change
| override async gather( | |
| async gather( |
There was a problem hiding this comment.
I have read the issue.
It is not necessary.
But to add override is requested in the issue?
| @@ -70,11 +70,11 @@ export class Source extends BaseSource<Params> { | |||
| }; | |||
| } | |||
|
|
|||
| params() { | |||
| override params() { | |||
There was a problem hiding this comment.
Suggested change
| override params() { | |
| params() { |
There was a problem hiding this comment.
Same with microsoft/TypeScript#47250.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overridekeyword is needed.