[WIP] Promise #526

rhysd · 2017-06-10T19:33:51Z

In Vim8 or Neovim, some asynchronous operations are added like job, channel or timer. They're recommended because async operations don't block user input. However, we don't want to see nested callbacks like good old JavaScript. In ES6 or later, Promise is one of the answers to callbacks hell.

APIs are almost the same as ECMAScript (ECMA-262) spec. And MDN is also a good documentation for Promise. (Japanese or English)

Promise is a unidirectional state machine like following figure (pending state will move to fulfilled or rejected, but fulfilled or rejected states cannot move to pending):

I ported ES6 promise to Vim script. I finished only library implementation. Tests and docs should be added. But I created this PR because I want to discuss some points before writing tests and docs. I referred es6-promise a lot, which is the most popular JavaScript Promise polyfill.

let s:P = vital#vital#import('Promise')

" Use '.then' for chaining async operations
let p = s:P.new({resolve -> timer_start(1000, resolve)})
call p.then({-> execute('echom "1sec!"', '')})

" Use '.catch' for chaining async error handlings
let p = s:P.new({_, reject -> timer_start(500, {-> reject('Too late')})})
call p.catch({reason -> execute('echom "error! reason:" . reason', '')})

let waits = [1000, 500, 2000, 1500]

" Order of fulfillment: 1 -> 0 -> 3 -> 2
let wait_all = s:P.all(map(waits, {idx, w -> s:P.new({resolve -> timer_start(w, {-> resolve(idx)})})}))

" Output: [0, 1, 2, 3]
call wait_all.then({arr -> execute('echom string(arr)', '')})

Supported APIs are below:

s:Promise.new(resolver) makes a new promise value (corresponding to new Promise(resolver) in JS.
s:Promise.resolve(val)
s:Promise.reject(val)
{promise value}.then(on_fulfilled[, on_rejected])
{promise value}.catch(on_rejected)
s:Promise.all(array)
s:Promise.race(array)
s:Promise.is_promise(val) returns val is a promise or not as boolean
s:Promise.is_available() returns whether this module is available or not in current environment

bluebird has more nice APIs. But I add only standard APIs in this PR.

Note that this library is currently only for Vim8 because internally lambda expressions are used. I need to rewrite them with Partial later. I'm considering to support Neovim and Vim8+.

Japanese blogpost

1. `s:Promise.new`

In JavaScript, new Promise((resolve, reject) => ...) works nicely. ~~However, in Vim script, we need to start argument with upper case as below because parameters of the lambda are funcref and not prefixed with a:.~~ Func ref arguments of lambda can start with lower case.

let p = s:Promise.new({resolve, reject -> resolve(42)})

I feel this does not look not so good. My idea is changing API of s:Promise.new as following.

let p = s:Promise.new({e -> e.resolve(42)})

Here, the e is an 'executor', which has fulfillment function and rejection function as its properties. (As bonus of this idea, I guess Vim7 can also be supported.) However, this interface is different from JS. It may be confusing for the people who knows JS's promise. What do you think?

2. Default result value of fulfillment

In JavaScript, default fulfilled result is undefined as below.

console.log(Promise.resolve()) // output: undefined

However, Vim script does not have such a good(?) default value like that. Currently I use v:null for the purpose. However 0 may be more suitable because :function's default value is 0.

3. How to test async operations with vim-themis

This is just a question. How can I test async operations with vim-themis? I could not find an interface for them. For example, mocha can wait async results with done callback.

it('does something', function(done) {
  setTimeout(done, 1000)
}

4. Module name

Currently I put this module as Vital.Promise. But it may not be appropriate. Candidates are below.

Vital.Promise (for now)
Vital.Async.Promise (may consider other asynchronous types such as observable)
Vital.Data.Promise (but is promise a data structure? 'data structure' is so fuzzy word...)

Both English and Japanese comments are welcome! Give me your thoughts.

vim-jp-bot · 2017-06-10T19:34:32Z

autoload/vital/__vital__/Promise.vim

+    elseif settled == s:REJECTED
+      let CB = a:promise._rejections[i]
+    else
+      throw 'vital:Promise: Cannot publish a pending promise'


[vital-throw-message] _{reported by reviewdog 🐶}
use vital: Promise: prefix to throw message

rhysd · 2017-06-10T19:34:35Z

コードレビューはまだできるレベルになってませんが，上記3点相談させてください！

vim-jp-bot · 2017-06-10T19:35:28Z

autoload/vital/__vital__/Promise.vim

+    call s:_subscribe(
+          \ a:thenable,
+          \ v:null,
+          \ {Val -> s:_resolve(a:promise, Val)},


[vint] _{reported by reviewdog 🐶}
unexpected token: > (see ynkdir/vim-vimlparser)

vim-jp-bot · 2017-06-10T19:38:22Z

autoload/vital/__vital__/Promise.vim

+    call s:_subscribe(
+          \ a:thenable,
+          \ v:null,
+          \ {Val -> s:_resolve(a:promise, Val)},


[vimlint] _{reported by reviewdog 🐶}
EVP_0: unexpected token: >

thinca · 2017-06-10T20:33:22Z

let p = s:Promise.new({e -> e.resolve(42)})

👍 This also has extensibility.

Or... should not we omit the result value? Is it inconvenient?
(This is difficult problem.)

How can I test async operations with vim-themis?

Unfortunately, there is no way to do that. I want to support it.
BTW, latest version of mocha can async test by returning the Promise object. I like this.
https://mochajs.org/#working-with-promises

rhysd · 2017-06-11T03:50:37Z

@thinca

コメントありがとうございます．

👍 This also has extensibility.

たしかに🦀

Or... should not we omit the result value? Is it inconvenient?

はい，デフォルトで _result キーがセットされていないと，_result の値を参照する時に毎回 has_key でチェックしてキーがあるときとないときで別処理を書く必要があります．しかしそれだけなので実装すれば良いだけの話かも… JS と違って Vim script は関数呼び出しで引数不足しているとエラーになるので，1引数のラムダ式で .then で受けていたのに実は値がなくてエラーとなるとエラーメッセージが分かりにくいかもしれないです．

BTW, latest version of mocha can async test by returning the Promise object. I like this.

超同意なんですが，それにはこの PR が入る必要があり，デッドロック… 多分 Promise のテストのために Promise に依存した機能を使うのはテストが落ちた時に切り分けが面倒になりそうです．

非同期なテストについては @lambdalisue さんの System.Job のテストを参考にさせてもらえば良いのかもしれないです．

tyru · 2017-06-11T05:25:00Z

@rhysd ++

let p = s:Promise.new({e -> e.resolve(42)})

自分もこっちのがいいと思います。理由は以下2点です。

ES Promise で現状サポートされてない cancel が入るかもしれないという話もある
- 「元々のPromise仕様では、ある値の非同期の読み込みが進行しているときに、それをキャンセルすることの意味は考慮されていませんでした」 via POSTD and Presentation
引数が増えた時 JS と違って Vim script では引数の数が正確に合ってないとエラーが出る

あとちなみにですが、

we need to start argument with upper case

その必要はないはずです。
a: 変数はもともと Funcref であっても upper case である必要がなく、
加えて lambda の引数は a: を省略できますが、内部的には a: を補間してくれてるだけみたいです（実際今以下を試して大丈夫でした）。

function! Succ(value)
  return a:value + 1
endfunction
" echo 2
echo {resolve,reject -> resolve(1)}(function('Succ'), function('Succ'))

rhysd · 2017-06-11T05:36:10Z

@tyru

ES Promise で現状サポートされてない cancel が入るかもしれないという話もある

確かに．cancelable promise の話は確か ES Promise では実装しないとなったと思いますが，Vim script では実装するという選択肢はありますね．@thinca さんのおっしゃるように拡張性を担保する価値がありそうです．

引数が増えた時 JS と違って Vim script では引数の数が正確に合ってないとエラーが出る

~~これはラムダ式については若干違います．例を拝借して少しいじると…~~

function! Succ(value)
  return a:value + 1
endfunction
" echo 2
echo {resolve -> resolve(1)}(function('Succ'), function('Succ'))

これでもエラーは出ません．どうやら引数が少ない分にはエラーが出ません（ただ，どうやら undocumented なので依存しないほうが良いかもしれません）

すみません，増えた時と書かれてました…つまり {resolve, reject, cancel -> ...} みたいに引数を増やしたくなった時に困るということですよね？

その必要はないはずです。
a: 変数はもともと Funcref であっても upper case である必要がなく、
加えて lambda の引数は a: を省略できますが、内部的には a: を補間してくれてるだけみたいです（実際今以下を試して大丈夫でした）。

あれ，おっしゃる通りでした… 僕が勘違いしていました．ありがとうございます．ただしこれは内部実装に依存した話でドキュメントにはざっと見た感じ明記されていない気がしました．

rhysd · 2017-06-11T14:48:55Z

議論したい項目に 4. モジュール名を追加しました．個人的には Vital.Async.Promise が良いのかな？と思うのですが，どうでしょう？

tyru · 2017-06-12T04:32:54Z

Vital.Async.Promise

👍

thinca · 2017-06-19T05:57:35Z

Async.*** になりそうな他のモジュールの候補って現時点で何か想定ありますか?

rhysd · 2017-06-19T10:20:38Z

一応脳内で想定していたのは Async.Observable です．こないだ @tyru さんがそんな感じのことをおっしゃっていたので…

lambdalisue · 2017-11-06T11:42:22Z

autoload/vital/__vital__/Promise.vim

+
+" Internal APIs
+
+" TODO: v:null or 0, which should the default result value be ?


👍 for v:null

codecov · 2017-12-16T06:46:33Z

Codecov Report

Merging #526 into master will increase coverage by 0.11%.
The diff coverage is 86.33%.

@@            Coverage Diff             @@
##           master     #526      +/-   ##
==========================================
+ Coverage   78.53%   78.65%   +0.11%     
==========================================
  Files          71       72       +1     
  Lines        8406     8545     +139     
==========================================
+ Hits         6602     6721     +119     
- Misses       1804     1824      +20

Impacted Files	Coverage Δ
autoload/vital/__vital__/Async/Promise.vim	`86.33% <86.33%> (ø)`
autoload/vital/__vital__/Random/Mt19937ar.vim	`93.68% <0%> (-1.06%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef5ac27...e5f6d5c. Read the comment docs.

rhysd · 2017-12-16T09:27:45Z

質問項目の 1. について考えてみたんですが，やはり {resolve, reject -> expr} のほうが {exe -> expr} より良いかなと思っています．

.then の引数は .then(resolve, reject) で，そことの対応が崩れてしまうのと，ES6 の Promise のインターフェースからやはりなるべく外したくないというのが意図です．

Vim script のラムダ式の引数は ... が暗黙的に引数末尾に追加されるというのを知ったので，.new() するときにも reject は書かなくて良い（s:P.new({resolve -> ... }）のと，ラムダ式を使わない場合でも，

function s:resolveFoo(resolve, ...)
  " do something ...
  let foo = ...
  resolve(foo)
endfunction

みたいな感じで ... を書いてもらえれば良いかなと．さらに，このプルリクをつくった時点では neovim にラムダ式が入っていなかったのでそこも懸念点でしたが，今は普通に使えるようですし．

tyru · 2017-12-16T09:37:38Z

Vim script のラムダ式の引数は ... が暗黙的に引数末尾に追加される

知らなかった…
.then(resolve, reject) 👍

vim-jp-bot · 2017-12-17T17:43:18Z

autoload/vital/__vital__/Async/Promise.vim

+    elseif settled == s:REJECTED
+      let CB = a:promise._rejections[i]
+    else
+      throw 'vital:Promise: Cannot publish a pending promise'


[vital-throw-message] _{reported by reviewdog 🐶}
use vital: Async.Promise: prefix to throw message

vim-jp-bot · 2017-12-17T17:44:16Z

autoload/vital/__vital__/Async/Promise.vim

+    call s:_subscribe(
+          \ a:thenable,
+          \ v:null,
+          \ {result -> s:_resolve(a:promise, result)},


[vint] _{reported by reviewdog 🐶}
unexpected token: > (see ynkdir/vim-vimlparser)

vim-jp-bot · 2017-12-17T17:47:39Z

autoload/vital/__vital__/Async/Promise.vim

+    call s:_subscribe(
+          \ a:thenable,
+          \ v:null,
+          \ {result -> s:_resolve(a:promise, result)},


[vimlint] _{reported by reviewdog 🐶}
EVP_0: unexpected token: >

vim-jp-bot · 2017-12-17T17:52:52Z

autoload/vital/__vital__/Async/Promise.vim

+    elseif settled == s:REJECTED
+      let CB = a:promise._rejections[i]
+    else
+      throw 'vital:Promise: Cannot publish a pending promise'


[vital-throw-message] _{reported by reviewdog 🐶}
use vital: Async.Promise: prefix to throw message

vim-jp-bot · 2017-12-17T17:53:45Z

autoload/vital/__vital__/Async/Promise.vim

+    elseif settled == s:REJECTED
+      let CB = a:promise._rejections[i]
+    else
+      throw 'vital:Async.Promise: Cannot publish a pending promise'


[vital-throw-message] _{reported by reviewdog 🐶}
use vital: Async.Promise: prefix to throw message

vim-jp-bot · 2017-12-17T17:55:47Z

autoload/vital/__vital__/Async/Promise.vim

+    elseif settled == s:REJECTED
+      let CB = a:promise._rejections[i]
+    else
+      throw 'vital:Async.Promise: Cannot publish a pending promise'


[vital-throw-message] _{reported by reviewdog 🐶}
use vital: Async.Promise: prefix to throw message

vim-jp-bot · 2017-12-17T17:58:57Z

autoload/vital/__vital__/Async/Promise.vim

+    elseif settled == s:REJECTED
+      let CB = a:promise._rejections[i]
+    else
+      throw 'vital:Promise: Cannot publish a pending promise'


[vital-throw-message] _{reported by reviewdog 🐶}
use vital: Async.Promise: prefix to throw message

vim-jp-bot · 2017-12-17T18:01:35Z

autoload/vital/__vital__/Async/Promise.vim

+    elseif settled == s:REJECTED
+      let CB = a:promise._rejections[i]
+    else
+      throw 'vital:Async.Promise: Cannot publish a pending promise'


[vital-throw-message] _{reported by reviewdog 🐶}
use vital: Async.Promise: prefix to throw message

lambdalisue · 2017-12-22T04:26:02Z

Vim の maxdepth 難しい。

話は違うかもしれませんが gina だと job の callback の中で sleep 1m を呼ぶと、その部分から別のコールバックが呼ばれたように扱われてしまい maxdepth に到達したことがあります（sleep で処理が別に渡るので、その部分から job の別のコールバックが呼ばれる形になって再起になるから maxdepth に到達する）

上記があるのでもしかすると then の中で sleep 呼ぶと同じ現象になるかもしれません。

rhysd · 2017-12-22T04:31:22Z

なるほど partial 使ったほうが良さげかもですね．下記の順序で修正してみます:

既存実装と timer_start 噛ました版でどれくらいパフォーマンスが違うか確認
テスト修正
ラムダ式ではなく partial 使うようにする
ドキュメント作成

ちなみに上記実装では funcmaxdepth の問題は（指摘いただいている :sleep の話以外は）解消しているようにみえるので，コールスタックの深さは気にしなくて良いように思います．

lambdalisue · 2017-12-22T04:38:55Z

ありがとうございますー
他の部分のレビューはその後の方が良いでしょうか？

rhysd · 2017-12-22T10:38:38Z

はい、WIP 外れたらでお願いします（いくつか修正すべき点があるのは認識済みです）

rhysd · 2017-12-22T10:42:28Z

ざっくりベンチマーク取ってみたのですが、timer_start が2回噛むほうは14倍ぐらい遅いですね

timer_start なし同期実行版 .then で10000回 .then をつなげてみる

vim -X -N -u NONE -i NONE -V1 -e -s -S run_bench.vim  4.13s user 0.48s system 26% cpu 17.689 total

timer_start あり非同期実行版 .then で10000回 .then をつなげてみる

vim -X -N -u NONE -i NONE -V1 -e -s -S run_bench.vim  22.28s user 0.03s system 85% cpu 26.054 total

partial 使った版も見てみましたがほぼ変わりませんでした（タイマー発火部分が支配的っぽい）

lambdalisue · 2017-12-22T10:58:47Z

はい、WIP 外れたらでお願いします

フライングすみません 🙇 💦

lambdalisue · 2017-12-22T11:15:27Z

個人的には非同期の時と同期の時とで、ベンチマークを比較することにあんまり意味ないかなと思います（メインスレッドの忙しさで14倍以上になりえるので）。

どちらかというと then のチェインが実行されている間でもカーソルが動かせる等、メインスレッドを占有していないか？の方が今回の場合は重要な気がします（そして、それを定量的に測るのは難しすぎる）

lambdalisue · 2017-12-22T11:17:10Z

↑ にしても 14 倍はちょっと‥‥と思うところもありますねw

rhysd · 2017-12-22T12:17:31Z

10000回の .then を実行しながら入力を確認してみたところ，:so によるスクリプトの評価が終わってからはユーザ入力はスムーズに行えますね．なので，.then のチェインの発火を待っている間にユーザの入力を阻害することはないみたいです．

14倍と言っても，1回の .then の呼び出しによるチェインの呼び出しラグは手元ですごく雑に測った感じだと1ミリ秒ほどでした

… called

because it is usually shorter and faster. (As long as I measured, partial is 10% faster than lambda when some variable is captured.

vim-jp-bot · 2017-12-23T15:35:01Z

autoload/vital/__vital__/Async/Promise.vim

+  elseif has_callback && success
+    call s:_resolve(a:promise, Result)
+  elseif !success
+    call s:_reject(a:promise, Err)


[vimlint] _{reported by reviewdog 🐶}
EVL104: variable may not be initialized on some execution path: l:Err

vim-jp-bot · 2017-12-24T02:04:54Z

autoload/vital/__vital__/Async/Promise.vim

+  elseif has_callback && success
+    call s:_resolve(a:promise, Result)
+  elseif !success
+    call s:_reject(a:promise, Err)


[vimlint] _{reported by reviewdog 🐶}
EVL104: variable may not be initialized on some execution path: l:Err

vim-jp-bot · 2017-12-24T02:04:59Z

autoload/vital/__vital__/Async/Promise.vim

+  elseif has_callback && success
+    call s:_resolve(a:promise, Result)
+  elseif !success
+    call s:_reject(a:promise, Err)


[vimlint] _{reported by reviewdog 🐶}
EVL104: variable may not be initialized on some execution path: l:Err

vim-jp-bot · 2017-12-24T02:05:02Z

autoload/vital/__vital__/Async/Promise.vim

+  elseif has_callback && success
+    call s:_resolve(a:promise, Result)
+  elseif !success
+    call s:_reject(a:promise, Err)


[vimlint] _{reported by reviewdog 🐶}
EVL104: variable may not be initialized on some execution path: l:Err

何回言うねん

vim-jp-bot · 2017-12-24T05:11:08Z

autoload/vital/__vital__/Async/Promise.vim

+  elseif has_callback && success
+    call s:_resolve(a:promise, Result)
+  elseif !success
+    call s:_reject(a:promise, Err)


[vimlint] _{reported by reviewdog 🐶}
EVL104: variable may not be initialized on some execution path: l:Err

vim-jp-bot · 2017-12-24T05:11:13Z

autoload/vital/__vital__/Async/Promise.vim

+  elseif has_callback && success
+    call s:_resolve(a:promise, Result)
+  elseif !success
+    call s:_reject(a:promise, Err)


[vimlint] _{reported by reviewdog 🐶}
EVL104: variable may not be initialized on some execution path: l:Err

vim-jp-bot · 2017-12-24T05:11:15Z

autoload/vital/__vital__/Async/Promise.vim

+  elseif has_callback && success
+    call s:_resolve(a:promise, Result)
+  elseif !success
+    call s:_reject(a:promise, Err)


[vimlint] _{reported by reviewdog 🐶}
EVL104: variable may not be initialized on some execution path: l:Err

vim-jp-bot · 2017-12-24T15:08:57Z

autoload/vital/__vital__/Async/Promise.vim

+  elseif has_callback && success
+    call s:_resolve(a:promise, Result)
+  elseif !success
+    call s:_reject(a:promise, Err)


[vimlint] _{reported by reviewdog 🐶}
EVL104: variable may not be initialized on some execution path: l:Err

vim-jp-bot · 2017-12-24T15:09:05Z

autoload/vital/__vital__/Async/Promise.vim

+  elseif has_callback && success
+    call s:_resolve(a:promise, Result)
+  elseif !success
+    call s:_reject(a:promise, Err)


[vimlint] _{reported by reviewdog 🐶}
EVL104: variable may not be initialized on some execution path: l:Err

vim-jp-bot · 2017-12-24T15:09:08Z

autoload/vital/__vital__/Async/Promise.vim

+  elseif has_callback && success
+    call s:_resolve(a:promise, Result)
+  elseif !success
+    call s:_reject(a:promise, Err)


[vimlint] _{reported by reviewdog 🐶}
EVL104: variable may not be initialized on some execution path: l:Err

rhysd · 2017-12-24T16:26:06Z

I created another PR #567 to review this library because this PR's timeline is too long. Please leave review comments there.

vim-jp-bot reviewed Jun 10, 2017

View reviewed changes

rhysd added the WIP label Aug 26, 2017

lambdalisue reviewed Nov 6, 2017

View reviewed changes

rhysd force-pushed the promise branch from 301ef3e to 0d4032f Compare December 16, 2017 06:39

rhysd force-pushed the promise branch 2 times, most recently from 1be6b86 to fc10a6d Compare December 17, 2017 17:42

vim-jp-bot reviewed Dec 17, 2017

View reviewed changes

rhysd force-pushed the promise branch from 3c5b3af to 7074764 Compare December 17, 2017 17:55

vim-jp-bot reviewed Dec 17, 2017

View reviewed changes

Promise: first implementation based on es6-promise

80c41b7

rhysd added 5 commits December 23, 2017 19:33

Async.Promise: Ensure fulfilled/rejected callbacks are asynchronously…

1708702

… called

Async.Promise: Fix tests for asynchronous fulfillment/rejection

83916a4

test: sweep sleep() with fixed time

b5b3f4a

impl: prefer partial to lambda

beaee61

because it is usually shorter and faster. (As long as I measured, partial is 10% faster than lambda when some variable is captured.

test: resolve/reject with funcref

6faf65b

vim-jp-bot reviewed Dec 23, 2017

View reviewed changes

test: P.reject() and P.resolve() with pending Promise

63de1ea

vim-jp-bot reviewed Dec 24, 2017

View reviewed changes

Async.Promise: Add a help document

3300ee8

vim-jp-bot reviewed Dec 24, 2017

View reviewed changes

doc: add a missing tag and tweak description of Promise object

7170440

vim-jp-bot reviewed Dec 24, 2017

View reviewed changes

rhysd mentioned this pull request Dec 24, 2017

Review: Async.Promise #567

Merged

rhysd closed this Dec 24, 2017


		" Internal APIs

		" TODO: v:null or 0, which should the default result value be ?

[WIP] Promise #526

[WIP] Promise #526

Conversation

rhysd commented Jun 10, 2017 • edited Loading

1. s:Promise.new

2. Default result value of fulfillment

3. How to test async operations with vim-themis

4. Module name

Choose a reason for hiding this comment

rhysd commented Jun 10, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thinca commented Jun 10, 2017

rhysd commented Jun 11, 2017 • edited Loading

tyru commented Jun 11, 2017

rhysd commented Jun 11, 2017 • edited Loading

rhysd commented Jun 11, 2017

tyru commented Jun 12, 2017 • edited Loading

thinca commented Jun 19, 2017

rhysd commented Jun 19, 2017

Choose a reason for hiding this comment

codecov bot commented Dec 16, 2017 • edited Loading

Codecov Report

rhysd commented Dec 16, 2017

tyru commented Dec 16, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lambdalisue commented Dec 22, 2017

rhysd commented Dec 22, 2017 • edited Loading

lambdalisue commented Dec 22, 2017

rhysd commented Dec 22, 2017

rhysd commented Dec 22, 2017

lambdalisue commented Dec 22, 2017

lambdalisue commented Dec 22, 2017

lambdalisue commented Dec 22, 2017

rhysd commented Dec 22, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rhysd commented Dec 24, 2017 • edited Loading

rhysd commented Jun 10, 2017 •

edited

Loading

1. `s:Promise.new`

rhysd commented Jun 11, 2017 •

edited

Loading

rhysd commented Jun 11, 2017 •

edited

Loading

tyru commented Jun 12, 2017 •

edited

Loading

codecov bot commented Dec 16, 2017 •

edited

Loading

rhysd commented Dec 22, 2017 •

edited

Loading

rhysd commented Dec 22, 2017 •

edited

Loading

rhysd commented Dec 24, 2017 •

edited

Loading