Detect constraints errors #403

Shougo · 2024-08-06T06:18:13Z

I have added the check for denops.vim.

Summary by CodeRabbit

New Features
- Enhanced error handling for connection issues, providing clearer diagnostics related to Deno module cache problems.
- Added warning messages that guide users on resolving connection failures by updating the module cache and restarting the editor.

coderabbitai · 2024-08-06T06:18:19Z

Walkthrough

The recent changes enhance error handling in the denops#_internal#server#chan#connect function within the chan.vim file. A new catch block was added to manage exceptions related to Deno module cache issues, allowing users to receive clear guidance for resolving connection failures. This improvement aims to provide a better user experience by ensuring informative diagnostics during such errors.

Changes

Files	Change Summary
autoload/denops/_internal/server/chan.vim	Enhanced error handling in `denops#_internal#server#chan#connect` for Deno module cache issues with debug messages.

Assessment against linked issues

Objective	Addressed	Explanation
Could not connect servers on launch time (401)	✅
Improve user diagnostics on connection failures (401)	✅

Poem

In the land of code where bunnies hop,
A fix was made, now no connection flop!
With messages clear, the users cheer,
Cache issues solved, no need to fear.
Hopping through errors, we dance with glee,
A brighter path for us all, you see! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between fcc579b and 715962f.

Files selected for processing (1)

autoload/denops/_internal/server/chan.vim (1 hunks)

Additional comments not posted (1)

autoload/denops/_internal/server/chan.vim (1)

173-184: LGTM! The new catch block improves error handling.

The added catch block effectively handles specific Deno module cache issues and provides clear guidance to users.

codecov · 2024-08-06T06:21:49Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.52%. Comparing base (e5824b0) to head (1ab769e).
Report is 5 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #403   +/-   ##
=======================================
  Coverage   95.52%   95.52%           
=======================================
  Files          23       23           
  Lines        1384     1384           
  Branches      174      174           
=======================================
  Hits         1322     1322           
  Misses         59       59           
  Partials        3        3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lambdalisue

LGTM but I'd like to hear @Milly's opinion if the code is written in a right section.

Milly · 2024-08-06T20:31:15Z

autoload/denops/_internal/server/chan.vim

@@ -170,6 +170,18 @@ function! s:reconnect(options) abort
        \))
  try
    call s:connect(s:addr, a:options)
+  catch /Could not find constraint\|Could not find version of/


This probably won't be caught.
I think #401 occurs in denops#server#start().
And the error message is outputs on here:

denops.vim/autoload/denops/_internal/server/proc.vim

Lines 87 to 93 in f5bcc4f

function! s:on_stderr(data) abort

echohl ErrorMsg

for l:line in split(a:data, '\n')

echomsg printf('[denops] %s', substitute(l:line, '\t', ' ', 'g'))

endfor

echohl None

endfunction

Use denops#_internal#echo#warn() instead debug.

I have changed it to use warn.

This probably won't be caught.

I don't think so. Because of the error message.

[denops] Server stopped (1). Restarting... [denops] Failed to connect channel ``: Vim(let):connection failed: tcp address must be host:port

The error messages are only printed the function.

catch call denops#_internal#echo#debug(printf( \ 'Failed to reconnect channel `%s` [%d/%d]: %s', \ s:addr, \ s:reconnect_count, \ a:options.reconnect_threshold, \ v:exception, \)) call s:schedule_reconnect(a:options) endtry

Oh, my bad.

denops#_internal#server#chan#connect() is correct instead.

The error message breaks down as follows:

Outputs at s:on_exit() in autoload/denops/_internal/server/proc.vim:

[denops] Server stopped (1). Restarting...

Outputs at denops#_internal#server#chan#connect():

[denops] Failed to connect channel ``: Vim(let):connection failed: tcp address must be host:port

Note that it says channel ``:, which means addr is an empty string, so the local server will not start correctly. This is another bug caused by missing error handling.
If addr is empty, DenopsSystemProcessListen:addr event should not be fired, but this is a different scope so a separate PR would be better.

Outputs at s:on_stderr() in autoload/denops/_internal/server/proc.vim:

[denops] error: Could not find constraint in the list of versions: @std/async@^1.0.1 [denops] Specifier: jsr:@std/async@^1.0.1/deadline [denops] at file:///Users/giginet/.local/share/nvim/lazy/denops.vim/denops/@denops-private/cli.ts:5:26

Note that this is not a part of the connect() error message.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 715962f and b3206a6.

Files selected for processing (1)

autoload/denops/_internal/server/chan.vim (1 hunks)

Files skipped from review as they are similar to previous changes (1)

autoload/denops/_internal/server/chan.vim

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b3206a6 and 1ab769e.

Files selected for processing (1)

autoload/denops/_internal/server/chan.vim (1 hunks)

Files skipped from review as they are similar to previous changes (1)

autoload/denops/_internal/server/chan.vim

Detect constraints errors

715962f

Shougo requested a review from lambdalisue August 6, 2024 06:18

coderabbitai bot reviewed Aug 6, 2024

View reviewed changes

lambdalisue requested a review from Milly August 6, 2024 07:28

lambdalisue approved these changes Aug 6, 2024

View reviewed changes

Milly requested changes Aug 6, 2024

View reviewed changes

Use warn instead

b3206a6

coderabbitai bot reviewed Aug 7, 2024

View reviewed changes

Fix

1ab769e

coderabbitai bot reviewed Aug 7, 2024

View reviewed changes

Milly mentioned this pull request Aug 7, 2024

👍 show constraint error warning #404

Merged

Shougo closed this Aug 7, 2024

Shougo deleted the fix_constraints branch August 7, 2024 02:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Detect constraints errors #403

Detect constraints errors #403

Shougo commented Aug 6, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Aug 6, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

codecov bot commented Aug 6, 2024 •

edited

Loading

lambdalisue left a comment

Milly Aug 6, 2024 •

edited

Loading

Milly Aug 6, 2024

Shougo Aug 7, 2024

Shougo Aug 7, 2024

Shougo Aug 7, 2024

Milly Aug 7, 2024

Shougo Aug 7, 2024

coderabbitai bot left a comment

coderabbitai bot left a comment

	function! s:on_stderr(data) abort
	echohl ErrorMsg
	for l:line in split(a:data, '\n')
	echomsg printf('[denops] %s', substitute(l:line, '\t', ' ', 'g'))
	endfor
	echohl None
	endfunction

Detect constraints errors #403

Detect constraints errors #403

Conversation

Shougo commented Aug 6, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Aug 6, 2024 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

codecov bot commented Aug 6, 2024 • edited Loading

Codecov Report

lambdalisue left a comment

Choose a reason for hiding this comment

Milly Aug 6, 2024 • edited Loading

Choose a reason for hiding this comment

Milly Aug 6, 2024

Choose a reason for hiding this comment

Shougo Aug 7, 2024

Choose a reason for hiding this comment

Shougo Aug 7, 2024

Choose a reason for hiding this comment

Shougo Aug 7, 2024

Choose a reason for hiding this comment

Milly Aug 7, 2024

Choose a reason for hiding this comment

Shougo Aug 7, 2024

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

Shougo commented Aug 6, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Aug 6, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Aug 6, 2024 •

edited

Loading

Milly Aug 6, 2024 •

edited

Loading