Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👍 add ^ prefix to dependency versions #394

Merged
merged 1 commit into from
Aug 3, 2024
Merged

Conversation

Milly
Copy link
Contributor

@Milly Milly commented Aug 3, 2024

Summary by CodeRabbit

  • New Features

    • No new features were introduced in this release.
  • Bug Fixes

    • No bug fixes were made in this release.
  • Refactor

    • Updated dependency versioning to caret (^) notation across multiple modules, allowing for more flexible and compatible version management of imported libraries.
  • Tests

    • Adjusted test imports to use caret (^) versioning for various dependencies, enhancing the adaptability and maintenance of the test suite.
  • Chores

    • General housekeeping for dependency management, ensuring the project is primed for future updates without functionality changes.

Copy link

coderabbitai bot commented Aug 3, 2024

Walkthrough

The recent updates primarily involve changing version specifications of various dependencies across multiple files from fixed versions to caret (^) notation. This adjustment allows for greater flexibility in dependency management, enabling the code to automatically incorporate minor and patch updates while maintaining compatibility. The overall functionality and logic of the code remain unchanged, enhancing maintainability without introducing new features.

Changes

Files Summary
denops/@denops-private/cli.ts, cli_test.ts Updated versioning format for imports using caret notation (^), enhancing dependency flexibility.
denops/@denops-private/denops.ts, denops_test.ts Consolidated import statements and changed version specifications to caret notation (^).
denops/@denops-private/error.ts, error_test.ts Updated import versions to caret (^) notation for enhanced flexibility in dependency updates.
denops/@denops-private/host.ts, host/*.ts Altered version specifications to caret notation (^) for various dependencies.
denops/@denops-private/service.ts, service_test.ts Changed versioning to caret (^), improving dependency management for imported modules.
denops/@denops-private/util.ts, version.ts Updated version specifications to caret (^) for better compatibility with future updates.
denops/@denops-private/worker.ts, worker_test.ts Modified imports to caret notation (^), enhancing flexibility in dependency management.
tests/.../*.ts Various updates across test files to use caret (^) versioning, improving maintainability.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CodeBase
    participant DependencyManager

    User->>CodeBase: Request feature
    CodeBase->>DependencyManager: Check for dependencies
    DependencyManager-->>CodeBase: Return compatible versions
    CodeBase->>User: Feature implemented with updated dependencies
Loading

🐇 "In the meadow, we hop and play,
With versions changing, come what may!
Caret notations bring us cheer,
New updates bloom, the path is clear.
With each small tweak, we dance and sing,
A rabbit’s joy in coding spring!" 🥕


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Aug 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.45%. Comparing base (8c920ec) to head (83ac196).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #394   +/-   ##
=======================================
  Coverage   95.44%   95.45%           
=======================================
  Files          23       23           
  Lines        1361     1363    +2     
  Branches      174      174           
=======================================
+ Hits         1299     1301    +2     
  Misses         59       59           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 8c920ec and 83ac196.

Files selected for processing (45)
  • denops/@denops-private/cli.ts (1 hunks)
  • denops/@denops-private/cli_test.ts (2 hunks)
  • denops/@denops-private/denops.ts (1 hunks)
  • denops/@denops-private/denops_test.ts (1 hunks)
  • denops/@denops-private/error.ts (1 hunks)
  • denops/@denops-private/error_test.ts (1 hunks)
  • denops/@denops-private/host.ts (1 hunks)
  • denops/@denops-private/host/nvim.ts (1 hunks)
  • denops/@denops-private/host/nvim_test.ts (1 hunks)
  • denops/@denops-private/host/vim.ts (1 hunks)
  • denops/@denops-private/host/vim_test.ts (1 hunks)
  • denops/@denops-private/host_test.ts (1 hunks)
  • denops/@denops-private/service.ts (1 hunks)
  • denops/@denops-private/service_test.ts (1 hunks)
  • denops/@denops-private/util.ts (1 hunks)
  • denops/@denops-private/version.ts (1 hunks)
  • denops/@denops-private/version_test.ts (1 hunks)
  • denops/@denops-private/worker.ts (1 hunks)
  • denops/@denops-private/worker_test.ts (1 hunks)
  • tests/denops/runtime/functions/plugin_test.ts (1 hunks)
  • tests/denops/runtime/functions/server_test.ts (1 hunks)
  • tests/denops/runtime/plugin_test.ts (1 hunks)
  • tests/denops/testdata/dummy_invalid_constraint_plugin.ts (1 hunks)
  • tests/denops/testdata/dummy_invalid_constraint_plugin2.ts (1 hunks)
  • tests/denops/testdata/dummy_invalid_dispose_plugin.ts (1 hunks)
  • tests/denops/testdata/dummy_invalid_plugin.ts (1 hunks)
  • tests/denops/testdata/dummy_invalid_wait_plugin.ts (1 hunks)
  • tests/denops/testdata/dummy_plugins/denops/@dummy_namespace/main.ts (1 hunks)
  • tests/denops/testdata/dummy_plugins/denops/dummy.invalid_name/main.ts (1 hunks)
  • tests/denops/testdata/dummy_plugins/denops/dummy_invalid/main.ts (1 hunks)
  • tests/denops/testdata/dummy_plugins/denops/dummy_valid/main.ts (1 hunks)
  • tests/denops/testdata/dummy_valid_dispose_plugin.ts (1 hunks)
  • tests/denops/testdata/dummy_valid_plugin.ts (1 hunks)
  • tests/denops/testdata/dummy_valid_wait_plugin.ts (1 hunks)
  • tests/denops/testdata/shared_server_test_no_verbose.ts (1 hunks)
  • tests/denops/testdata/shared_server_test_verbose_true.ts (1 hunks)
  • tests/denops/testutil/conf.ts (1 hunks)
  • tests/denops/testutil/conf_test.ts (1 hunks)
  • tests/denops/testutil/mock.ts (1 hunks)
  • tests/denops/testutil/mock_test.ts (2 hunks)
  • tests/denops/testutil/shared_server.ts (1 hunks)
  • tests/denops/testutil/shared_server_test.ts (1 hunks)
  • tests/denops/testutil/wait.ts (1 hunks)
  • tests/denops/testutil/wait_test.ts (1 hunks)
  • tests/denops/testutil/with.ts (1 hunks)
Files skipped from review due to trivial changes (40)
  • denops/@denops-private/cli.ts
  • denops/@denops-private/cli_test.ts
  • denops/@denops-private/denops.ts
  • denops/@denops-private/denops_test.ts
  • denops/@denops-private/error.ts
  • denops/@denops-private/error_test.ts
  • denops/@denops-private/host.ts
  • denops/@denops-private/host/nvim.ts
  • denops/@denops-private/host/nvim_test.ts
  • denops/@denops-private/host/vim.ts
  • denops/@denops-private/host_test.ts
  • denops/@denops-private/service.ts
  • denops/@denops-private/util.ts
  • denops/@denops-private/version.ts
  • denops/@denops-private/version_test.ts
  • denops/@denops-private/worker.ts
  • denops/@denops-private/worker_test.ts
  • tests/denops/runtime/functions/plugin_test.ts
  • tests/denops/runtime/functions/server_test.ts
  • tests/denops/runtime/plugin_test.ts
  • tests/denops/testdata/dummy_invalid_constraint_plugin.ts
  • tests/denops/testdata/dummy_invalid_constraint_plugin2.ts
  • tests/denops/testdata/dummy_invalid_dispose_plugin.ts
  • tests/denops/testdata/dummy_invalid_plugin.ts
  • tests/denops/testdata/dummy_invalid_wait_plugin.ts
  • tests/denops/testdata/dummy_plugins/denops/@dummy_namespace/main.ts
  • tests/denops/testdata/dummy_plugins/denops/dummy.invalid_name/main.ts
  • tests/denops/testdata/dummy_plugins/denops/dummy_invalid/main.ts
  • tests/denops/testdata/dummy_plugins/denops/dummy_valid/main.ts
  • tests/denops/testdata/dummy_valid_dispose_plugin.ts
  • tests/denops/testdata/dummy_valid_wait_plugin.ts
  • tests/denops/testdata/shared_server_test_no_verbose.ts
  • tests/denops/testutil/conf.ts
  • tests/denops/testutil/mock.ts
  • tests/denops/testutil/mock_test.ts
  • tests/denops/testutil/shared_server.ts
  • tests/denops/testutil/shared_server_test.ts
  • tests/denops/testutil/wait.ts
  • tests/denops/testutil/wait_test.ts
  • tests/denops/testutil/with.ts
Additional comments not posted (15)
tests/denops/testdata/shared_server_test_verbose_true.ts (1)

1-1: LGTM! Ensure compatibility with the new version.

The change to the caret version allows for greater flexibility in dependency management. Ensure that the new version of @std/async is compatible with the existing code.

tests/denops/testdata/dummy_valid_plugin.ts (1)

1-1: LGTM! Ensure compatibility with the new version.

The change to the caret version allows for greater flexibility in dependency management. Ensure that the new version of @denops/core is compatible with the existing code.

tests/denops/testutil/conf_test.ts (1)

1-1: LGTM! Ensure compatibility with the new version.

The change to the caret version allows for greater flexibility in dependency management. Ensure that the new version of @std/assert is compatible with the existing code.

denops/@denops-private/host/vim_test.ts (6)

5-5: LGTM! Flexible versioning for @std/assert.

The change to caret (^) notation for versioning allows for more flexible dependency management.


11-11: LGTM! Flexible versioning for @std/testing.

The change to caret (^) notation for versioning allows for more flexible dependency management.


12-12: LGTM! Flexible versioning for @std/async.

The change to caret (^) notation for versioning allows for more flexible dependency management.


13-13: LGTM! Flexible versioning for @lambdalisue/async.

The change to caret (^) notation for versioning allows for more flexible dependency management.


14-14: LGTM! Flexible versioning for @lambdalisue/errorutil.

The change to caret (^) notation for versioning allows for more flexible dependency management.


15-15: LGTM! Flexible versioning for @denops/vim-channel-command.

The change to caret (^) notation for versioning allows for more flexible dependency management.

denops/@denops-private/service_test.ts (6)

12-12: LGTM! Flexible versioning for @std/assert.

The change to caret (^) notation for versioning allows for more flexible dependency management.


19-19: LGTM! Flexible versioning for @std/testing.

The change to caret (^) notation for versioning allows for more flexible dependency management.


20-20: LGTM! Flexible versioning for @denops/core.

The change to caret (^) notation for versioning allows for more flexible dependency management.


21-21: LGTM! Flexible versioning for @lambdalisue/async.

The change to caret (^) notation for versioning allows for more flexible dependency management.


22-22: LGTM! Flexible versioning for @lambdalisue/errorutil.

The change to caret (^) notation for versioning allows for more flexible dependency management.


25-25: LGTM! Flexible versioning for @std/path.

The change to caret (^) notation for versioning allows for more flexible dependency management.

@Milly Milly requested a review from lambdalisue August 3, 2024 01:48
Copy link
Member

@lambdalisue lambdalisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lambdalisue lambdalisue merged commit cd628cd into main Aug 3, 2024
9 checks passed
@lambdalisue lambdalisue deleted the no-exact-version branch August 3, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants