-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👍 add ^
prefix to dependency versions
#394
Conversation
WalkthroughThe recent updates primarily involve changing version specifications of various dependencies across multiple files from fixed versions to caret ( Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant CodeBase
participant DependencyManager
User->>CodeBase: Request feature
CodeBase->>DependencyManager: Check for dependencies
DependencyManager-->>CodeBase: Return compatible versions
CodeBase->>User: Feature implemented with updated dependencies
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #394 +/- ##
=======================================
Coverage 95.44% 95.45%
=======================================
Files 23 23
Lines 1361 1363 +2
Branches 174 174
=======================================
+ Hits 1299 1301 +2
Misses 59 59
Partials 3 3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (45)
- denops/@denops-private/cli.ts (1 hunks)
- denops/@denops-private/cli_test.ts (2 hunks)
- denops/@denops-private/denops.ts (1 hunks)
- denops/@denops-private/denops_test.ts (1 hunks)
- denops/@denops-private/error.ts (1 hunks)
- denops/@denops-private/error_test.ts (1 hunks)
- denops/@denops-private/host.ts (1 hunks)
- denops/@denops-private/host/nvim.ts (1 hunks)
- denops/@denops-private/host/nvim_test.ts (1 hunks)
- denops/@denops-private/host/vim.ts (1 hunks)
- denops/@denops-private/host/vim_test.ts (1 hunks)
- denops/@denops-private/host_test.ts (1 hunks)
- denops/@denops-private/service.ts (1 hunks)
- denops/@denops-private/service_test.ts (1 hunks)
- denops/@denops-private/util.ts (1 hunks)
- denops/@denops-private/version.ts (1 hunks)
- denops/@denops-private/version_test.ts (1 hunks)
- denops/@denops-private/worker.ts (1 hunks)
- denops/@denops-private/worker_test.ts (1 hunks)
- tests/denops/runtime/functions/plugin_test.ts (1 hunks)
- tests/denops/runtime/functions/server_test.ts (1 hunks)
- tests/denops/runtime/plugin_test.ts (1 hunks)
- tests/denops/testdata/dummy_invalid_constraint_plugin.ts (1 hunks)
- tests/denops/testdata/dummy_invalid_constraint_plugin2.ts (1 hunks)
- tests/denops/testdata/dummy_invalid_dispose_plugin.ts (1 hunks)
- tests/denops/testdata/dummy_invalid_plugin.ts (1 hunks)
- tests/denops/testdata/dummy_invalid_wait_plugin.ts (1 hunks)
- tests/denops/testdata/dummy_plugins/denops/@dummy_namespace/main.ts (1 hunks)
- tests/denops/testdata/dummy_plugins/denops/dummy.invalid_name/main.ts (1 hunks)
- tests/denops/testdata/dummy_plugins/denops/dummy_invalid/main.ts (1 hunks)
- tests/denops/testdata/dummy_plugins/denops/dummy_valid/main.ts (1 hunks)
- tests/denops/testdata/dummy_valid_dispose_plugin.ts (1 hunks)
- tests/denops/testdata/dummy_valid_plugin.ts (1 hunks)
- tests/denops/testdata/dummy_valid_wait_plugin.ts (1 hunks)
- tests/denops/testdata/shared_server_test_no_verbose.ts (1 hunks)
- tests/denops/testdata/shared_server_test_verbose_true.ts (1 hunks)
- tests/denops/testutil/conf.ts (1 hunks)
- tests/denops/testutil/conf_test.ts (1 hunks)
- tests/denops/testutil/mock.ts (1 hunks)
- tests/denops/testutil/mock_test.ts (2 hunks)
- tests/denops/testutil/shared_server.ts (1 hunks)
- tests/denops/testutil/shared_server_test.ts (1 hunks)
- tests/denops/testutil/wait.ts (1 hunks)
- tests/denops/testutil/wait_test.ts (1 hunks)
- tests/denops/testutil/with.ts (1 hunks)
Files skipped from review due to trivial changes (40)
- denops/@denops-private/cli.ts
- denops/@denops-private/cli_test.ts
- denops/@denops-private/denops.ts
- denops/@denops-private/denops_test.ts
- denops/@denops-private/error.ts
- denops/@denops-private/error_test.ts
- denops/@denops-private/host.ts
- denops/@denops-private/host/nvim.ts
- denops/@denops-private/host/nvim_test.ts
- denops/@denops-private/host/vim.ts
- denops/@denops-private/host_test.ts
- denops/@denops-private/service.ts
- denops/@denops-private/util.ts
- denops/@denops-private/version.ts
- denops/@denops-private/version_test.ts
- denops/@denops-private/worker.ts
- denops/@denops-private/worker_test.ts
- tests/denops/runtime/functions/plugin_test.ts
- tests/denops/runtime/functions/server_test.ts
- tests/denops/runtime/plugin_test.ts
- tests/denops/testdata/dummy_invalid_constraint_plugin.ts
- tests/denops/testdata/dummy_invalid_constraint_plugin2.ts
- tests/denops/testdata/dummy_invalid_dispose_plugin.ts
- tests/denops/testdata/dummy_invalid_plugin.ts
- tests/denops/testdata/dummy_invalid_wait_plugin.ts
- tests/denops/testdata/dummy_plugins/denops/@dummy_namespace/main.ts
- tests/denops/testdata/dummy_plugins/denops/dummy.invalid_name/main.ts
- tests/denops/testdata/dummy_plugins/denops/dummy_invalid/main.ts
- tests/denops/testdata/dummy_plugins/denops/dummy_valid/main.ts
- tests/denops/testdata/dummy_valid_dispose_plugin.ts
- tests/denops/testdata/dummy_valid_wait_plugin.ts
- tests/denops/testdata/shared_server_test_no_verbose.ts
- tests/denops/testutil/conf.ts
- tests/denops/testutil/mock.ts
- tests/denops/testutil/mock_test.ts
- tests/denops/testutil/shared_server.ts
- tests/denops/testutil/shared_server_test.ts
- tests/denops/testutil/wait.ts
- tests/denops/testutil/wait_test.ts
- tests/denops/testutil/with.ts
Additional comments not posted (15)
tests/denops/testdata/shared_server_test_verbose_true.ts (1)
1-1
: LGTM! Ensure compatibility with the new version.The change to the caret version allows for greater flexibility in dependency management. Ensure that the new version of
@std/async
is compatible with the existing code.tests/denops/testdata/dummy_valid_plugin.ts (1)
1-1
: LGTM! Ensure compatibility with the new version.The change to the caret version allows for greater flexibility in dependency management. Ensure that the new version of
@denops/core
is compatible with the existing code.tests/denops/testutil/conf_test.ts (1)
1-1
: LGTM! Ensure compatibility with the new version.The change to the caret version allows for greater flexibility in dependency management. Ensure that the new version of
@std/assert
is compatible with the existing code.denops/@denops-private/host/vim_test.ts (6)
5-5
: LGTM! Flexible versioning for @std/assert.The change to caret (^) notation for versioning allows for more flexible dependency management.
11-11
: LGTM! Flexible versioning for @std/testing.The change to caret (^) notation for versioning allows for more flexible dependency management.
12-12
: LGTM! Flexible versioning for @std/async.The change to caret (^) notation for versioning allows for more flexible dependency management.
13-13
: LGTM! Flexible versioning for @lambdalisue/async.The change to caret (^) notation for versioning allows for more flexible dependency management.
14-14
: LGTM! Flexible versioning for @lambdalisue/errorutil.The change to caret (^) notation for versioning allows for more flexible dependency management.
15-15
: LGTM! Flexible versioning for @denops/vim-channel-command.The change to caret (^) notation for versioning allows for more flexible dependency management.
denops/@denops-private/service_test.ts (6)
12-12
: LGTM! Flexible versioning for @std/assert.The change to caret (^) notation for versioning allows for more flexible dependency management.
19-19
: LGTM! Flexible versioning for @std/testing.The change to caret (^) notation for versioning allows for more flexible dependency management.
20-20
: LGTM! Flexible versioning for @denops/core.The change to caret (^) notation for versioning allows for more flexible dependency management.
21-21
: LGTM! Flexible versioning for @lambdalisue/async.The change to caret (^) notation for versioning allows for more flexible dependency management.
22-22
: LGTM! Flexible versioning for @lambdalisue/errorutil.The change to caret (^) notation for versioning allows for more flexible dependency management.
25-25
: LGTM! Flexible versioning for @std/path.The change to caret (^) notation for versioning allows for more flexible dependency management.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Summary by CodeRabbit
New Features
Bug Fixes
Refactor
Tests
Chores