🐛 Fix denops#plugin#wait_async

[lambdalisue]

Summary by CodeRabbit

• Bug Fixes
  • Improved callback handling in plugin scripts to ensure more reliable functionality.

[coderabbitai]

Walkthrough

The recent update to the Vim script involves a modification in the way callbacks are managed within the denops#plugin#wait_async function. Specifically, the key used in the dictionary for storing callbacks has been changed from a:plugin to a:name, ensuring more accurate handling of callback assignments.

Changes

File	Change Summary
autoload/denops/plugin.vim	Updated callback dictionary key from a:plugin to a:name

🐰✨ In the world of code, a change so slight,
A key renamed, bringing functions to light.
a:name now holds the callbacks tight,
Denops plugins, ready for the night.
With this tweak, our scripts take flight,
Hopping through lines, everything's just right.
🌙💻

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.01%. Comparing base (4cd759f) to head (c57834b).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #346   +/-   ##
=======================================
  Coverage   90.01%   90.01%           
=======================================
  Files           9        9           
  Lines         661      661           
  Branches       62       62           
=======================================
  Hits          595      595           
  Misses         66       66           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4cd759f and c57834b.

Files selected for processing (1)

• autoload/denops/plugin.vim (1 hunks)

Additional comments not posted (1)

autoload/denops/plugin.vim (1)

54-54: Ensure consistent use of a:name instead of a:plugin.

The change from a:plugin to a:name in the denops#plugin#wait_async function looks correct. Verify that there are no remaining references to a:plugin that should be updated to a:name.

Verification successful

---

No remaining references to a:plugin found in the codebase

The search for a:plugin across all file types did not produce any results, indicating that there are no remaining references to a:plugin that need to be updated to a:name.

Scripts Executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Description: Verify there are no remaining references to `a:plugin` in the codebase.

# Test: Search for the old key `a:plugin`. Expect: No occurrences.
rg --type vimscript $'a:plugin'

Length of output: 30

---

---

Script:

#!/bin/bash
# Description: Verify there are no remaining references to `a:plugin` in the codebase across all file types.

# Test: Search for the old key `a:plugin`. Expect: No occurrences.
rg 'a:plugin'

Length of output: 13