Respect minwidth for hunks and branch parts #1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the hardcoded minwidth limits for both the `hunks` and `branch` parts. It replaces these with safe accesses to the `minwidth` setting as done by `airline#parts#define_minwidth`.
|
Thanks looks good. One question: Why do you need |
|
The I'll add some documentation, no problem. |
This allows for advanced customization where the shortening of the branch name is up to the caller, unlike before. This change is observable from the outside, and as such can be dangerous. But AFAIK it does not change the default behavior.
maxnordlund
force-pushed
the
resepct-minwidth-for-vcs
branch
from
c4b4ebc to
b69aa39
Compare
|
Done, and I also got a warning about trailing white spaces from airline so I fixed that as well :) |
|
Thanks! |
YCbCr
pushed a commit
to YCbCr/vim-airline
that referenced
this pull request
May 26, 2019
…-for-vcs Respect minwidth for hunks and branch parts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, first let me thank you for an awesome vim plugin ❤️
This contains three related changes. First a fix to make
hunksandbranchrespectminwidthinstead of hard coding 100 and 120 respectively. I've done this very carefully to not break anything. Secondly a small tweak to allow advanced customization of thehunks. This just exposes the previouslys:functionget_hunksasget_raw_hunks.Finally, and this is the one I'm a bit unsure of, I move the branch name shortening from
headtoget_head, which meansb:airline_headisn't shortened anymore. All code inside this plugin are fine with this, as they only check if it's empty or not. But it's technically a breaking change, I think.If you don't like a commit, it can be easily rebased away. I'm looking forward to your feedback.