Denite extension not working

[petobens]

I've recently noticed that the denite extension doesn't seem to work. With the following minimal vimrc:

set nocompatible

let $DOTVIM = expand('$HOME/.config/nvim')

set runtimepath+=$DOTVIM/bundle/repos/github.com/vim-airline/vim-airline
set runtimepath+=$DOTVIM/bundle/repos/github.com/Shougo/denite.nvim
filetype plugin indent on

If I run :Denite file I simply get:

However AirlineExtensions shows denite to be loaded. I'm not sure this is a problem with airline or with denite though (cc @Shougo).

For the record I'm using nvim v0.4.0-252-gb3ce0019a

[chrisbra]

IIRC nothing changed on airlines side Am 2019-02-10 16:24, schrieb Pedro Ferrari:

…

I've recently noticed that the denite extension doesn't seem to work. With the following minimal vimrc: set nocompatible let $DOTVIM = expand('$HOME/.config/nvim') set runtimepath+=$DOTVIM/bundle/repos/github.com/vim-airline/vim-airline set runtimepath+=$DOTVIM/bundle/repos/github.com/Shougo/denite.nvim filetype plugin indent on If I run :Denite file I simply get: [1] However AirlineExtensions shows denite to be loaded. I'm not sure this is a problem with airline or with denite though (cc @Shougo [2]). For the record I'm using nvim v0.4.0-252-gb3ce0019a -- You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub [3], or mute the thread [4]. Links: ------ [1] https://user-images.githubusercontent.com/2583971/52535559-9c90ed80-2d2e-11e9-8a86-46bfd810bb87.png [2] https://github.com/Shougo [3] #1874 [4] https://github.com/notifications/unsubscribe-auth/AAO8v0k8yfPKrfnKn9hzpBJrHXSn6qJ-ks5vMDmsgaJpZM4azHBD

[petobens]

Yep, that's the strange thing. I actually tried reverting a few commits on both Airline and Denite side but cannot seem to make it work again...

[Shougo]

@petobens You should use git bisect instead.

[Shougo]

I have reproduced, but I don't know vim-airline implementation.
statusline option seems reset to empty.

[Shougo]

I get the reason. denite extension is broken.
denite#get_status_mode() may return empty string.

diff --git a/autoload/airline/extensions/denite.vim b/autoload/airline/extensions/denite.vim
index e3c1f3b..b637439 100644
--- a/autoload/airline/extensions/denite.vim
+++ b/autoload/airline/extensions/denite.vim
@@ -15,7 +15,7 @@ function! airline#extensions#denite#check_denite_mode(bufnr)
     return ''
   endif
   let mode = split(denite#get_status_mode(), ' ')
-  let mode = tolower(mode[1])
+  let mode = tolower(get(mode, 1, ''))
   if !exists('b:denite_mode_cache') || mode != b:denite_mode_cache
     call airline#highlighter#highlight([mode], a:bufnr)
     let b:denite_mode_cache = mode

[petobens]

@Shougo that works! Thank you :). Can you do a PR?

[Shougo]

You can send the PR.