Functions could differ when asserting component

viktor-podzigun · Jun 14, 2023 · 7afb787 · 7afb787
1 parent f61ec10
commit 7afb787
Show file tree

Hide file tree

Showing 2 changed files with 44 additions and 1 deletion.
diff --git a/src/assertComponent.mjs b/src/assertComponent.mjs
@@ -57,6 +57,8 @@ function assertComponentImpl(path, result, expectedElement) {
       const expectedValue = expectedElement.props[attr];
       if (typeof expectedValue === "object" && !Array.isArray(expectedValue)) {
         assertObject(`${pathName}.${attr}`, resultValue, expectedValue);
+      } else if (typeof expectedValue === "function") {
+        // functions could differ !!!
       } else {
         assertAttrValue(`${pathName}.${attr}`, resultValue, expectedValue);
       }
@@ -112,8 +114,10 @@ function assertObject(name, resultValue, expectedObject) {
     expectedKeys.forEach((key) => {
       const resultValue = resultObject[key];
       const expectedValue = expectedObject[key];
-      if (typeof expectedValue === "object") {
+      if (typeof expectedValue === "object" && !Array.isArray(expectedValue)) {
         assertObject(`${name}.${key}`, resultValue, expectedValue);
+      } else if (typeof expectedValue === "function") {
+        // functions could differ !!!
       } else {
         assertAttrValue(`${name}.${key}`, resultValue, expectedValue);
       }

diff --git a/test/assertComponent.test.mjs b/test/assertComponent.test.mjs
@@ -68,6 +68,35 @@ describe("assertComponent.test.mjs", () => {
     );
   });
 
+  it("should fail if function attribute doesn't match", () => {
+    //given
+    const Comp = () => {
+      return h("p", {
+        testObj: {
+          test: () => 1,
+        },
+      });
+    };
+    const comp = TestRenderer.create(h(Comp)).root.children[0];
+    /** @type {Error?} */
+    let resError = null;
+
+    //when
+    try {
+      assertComponent(comp, h("p", { testObj: { test: undefined } }));
+    } catch (error) {
+      resError = error;
+    }
+
+    //then
+    assert.deepEqual(
+      resError?.message,
+      "Attribute value doesn't match for p.testObj.test" +
+        "\n\tactual:   () => 1" +
+        "\n\texpected: undefined"
+    );
+  });
+
   it("should fail if boolean attribute doesn't match", () => {
     //given
     const Comp = () => {
@@ -205,13 +234,18 @@ describe("assertComponent.test.mjs", () => {
           id: id,
           hidden: true,
           height: 10,
+          arr: [1, 2],
+          test: undefined,
+          onPress: () => 1,
         },
         h("div", {
           testArr: ["test"],
           testObj: {
             test: 1,
             nested: {
               test2: 2,
+              arr2: [1, 2],
+              onPress2: () => 1,
             },
           },
         }),
@@ -232,13 +266,18 @@ describe("assertComponent.test.mjs", () => {
           id: id,
           hidden: true,
           height: 10,
+          arr: [1, 2],
+          test: undefined,
+          onPress: () => 2, // functions could differ !!!
         },
         h("div", {
           testArr: ["test"],
           testObj: {
             test: 1,
             nested: {
               test2: 2,
+              arr2: [1, 2],
+              onPress2: () => 2, // functions could differ !!!
             },
           },
         }),