Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config file #43

Merged
merged 8 commits into from
Aug 3, 2023
Merged

Add config file #43

merged 8 commits into from
Aug 3, 2023

Conversation

vandangnhathung
Copy link
Collaborator

Move classes and attributes in index.js to configs.js

@vandangnhathung vandangnhathung self-assigned this Aug 1, 2023
Copy link
Member

@phucbm phucbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phucbm phucbm merged commit 936efb3 into 2.1.8 Aug 3, 2023
@phucbm phucbm deleted the 2.1.8-add-config branch August 3, 2023 11:15
phucbm added a commit that referenced this pull request Aug 3, 2023
* Use events manger (#44)

* feat: use events manger

* fix: remove redundant code

* fix: add bracket for data-ea in DEFAULTS variable

* fix: format code

* fix: return default back

* fix: add comma

* fix: add comma

* fix: remove configs file and add on method

* fix: add comma

* fix: add comma

* fix: add bracket for target

* docs: update README.md

* Add config file (#43)

* feat: add config file

* fix: format code

* fix: add defaults to configs.js

* fix: add comma

* fix: add comma

* fix: replace fire event and add eventsManager

* fix: add on method

---------

Co-authored-by: Pau15122 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants