Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug scroll to viewport #30

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Bug scroll to viewport #30

merged 1 commit into from
Feb 13, 2023

Conversation

tung13041996
Copy link
Member

This pull request to fixed bug: click to item accordion, window will scroll to viewport.

@tung13041996 tung13041996 added the bug Something isn't working label Jan 20, 2023
@phucbm
Copy link
Member

phucbm commented Feb 3, 2023

I don't understand why "scroll to viewport" is a bug. Could you please explain more? In what case do we need this?

@phucbm
Copy link
Member

phucbm commented Feb 6, 2023

@tung13041996
Any update on this?

@tung13041996
Copy link
Member Author

@tung13041996 Any update on this?

I will update code for this issue because of bug in other project when update to newest version of ETA

@phucbm
Copy link
Member

phucbm commented Feb 8, 2023

@tung13041996

I don't understand why "scroll to viewport" is a bug. Could you please explain more? In what case do we need this?

  1. You have not answer this question.

@tung13041996 Any update on this?

I will update code for this issue because of bug in other project when update to newest version of ETA

  1. I ask for update because I want to know why did we not close this issue. Your answer did not help me to make any decision, and I think that you are prolonging. At least give me a deadline.

@vuquangpham
Copy link
Contributor

vuquangpham commented Feb 13, 2023

About the scrollIntoView method, we make the viewport jump to the wrapper of the target, that's wrong position,

@tung13041996
Copy link
Member Author

tung13041996 commented Feb 13, 2023

@phucbm First, I so sorry for missing notification for this issue. Then, I'll explain why it's a bug.
In all project, trigger is <a> with href=#...., so function assignTriggerElements in methods.js will run. So, when we click trigger, line 66 will run and scroll to wrapper. That's the reason I remove line 66.
image

@phucbm
Copy link
Member

phucbm commented Feb 13, 2023

Thank you @tung13041996, it's clear now.

Copy link
Member

@phucbm phucbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@phucbm phucbm changed the base branch from 2.1.3 to 2.1.4 February 13, 2023 09:24
@phucbm phucbm merged commit c2d790a into 2.1.4 Feb 13, 2023
@phucbm phucbm deleted the bug_scroll_to_viewport branch February 13, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants