Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight design changes to User Interface #220

Merged
merged 1 commit into from
Jul 30, 2021
Merged

Conversation

LeNitrous
Copy link
Member

image
image

Aside from this, there are also refactors to some namespaces and general cleanup.

+ remove `Backgrounds` namespace
+ use framework's `ScreenStack` and `Screen`
+ reorder namespacing
+ adjust settings tab
+ adjust home tab
- remove help tab
@LeNitrous LeNitrous added priority:low Bugs or Features that can be done but at a later time when resources are ample. area:user-interface labels Jul 29, 2021
@LeNitrous LeNitrous requested a review from sr229 July 29, 2021 13:37
@LeNitrous LeNitrous self-assigned this Jul 29, 2021
@sr229
Copy link
Member

sr229 commented Jul 29, 2021

Mentioning Vignette once more is a bit redundant so just title it as "Visit us" or similar in the website, or replace it with something else

Copy link
Member

@sr229 sr229 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check suggestion before I merge since it doesn't flow right to mention our name again

@LeNitrous
Copy link
Member Author

Mentioning Vignette once more is a bit redundant so just title it as "Visit us" or similar in the website, or replace it with something else

I'm not really satisfied with the buttons on the home page just yet since we don't have anything finalized yet. I'll leave it for another PR once we slowly have more things up and running by then.

Copy link
Member

@sr229 sr229 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scheduling an Insider build for this now, but before we release this on public, we should get that one sorted.

@sr229 sr229 merged commit e485401 into master Jul 30, 2021
@sr229 sr229 deleted the LeNitrous/ui-adjustments branch July 30, 2021 02:30
@sr229 sr229 restored the LeNitrous/ui-adjustments branch July 30, 2021 02:30
@LeNitrous LeNitrous deleted the LeNitrous/ui-adjustments branch November 4, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:user-interface priority:low Bugs or Features that can be done but at a later time when resources are ample.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants