[update] use newest, exact versions of webpack, karma, et al. #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are we into defining exact versions? If so, should we make them exact as we have need to, or should we proactively change them to be exact? |
|
Yikes. Good call. I am a fan of exact versions. Definitely for development dependencies. I've been doing this on a lot of projects now; I am surprised it isn't in CK already. For production dependencies, we should be more lenient to avoid duplication. Still, for development we can set exact versions of those dependencies for consistency. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webpackversion 1.7.3 andwebpack-dev-serverversion 1.10.1 [didn't get along]([see issue here]%28https://github.com/webpack/webpack/issues/1225%29).(https://s3.amazonaws.com/vigesharing-is-vigecaring/lkurtz/npm_start_node_2015-09-15_15-21-02.png)This PR updates package.json to the newest versions of these modules. It also starts defining dependencies with exact versions to avoid issues like this moving forward.
There was also an issue with
karmathat necessitated a version bump along with the webpack modules.