-
Notifications
You must be signed in to change notification settings - Fork 682
Descriptions are more tech-agnostic, and yarn syntax is up-to-date #574
Conversation
olets
commented
Mar 11, 2019
•
edited
Loading
edited
- Drops all mentions of gulp-starter, including in the logo and correcting some link paths.
- Tell users to use commands like
as opposed to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also wrong person to approve this since I don't use blendid but had a couple of q's and suggestions
@@ -1,17 +1,17 @@ | |||
# Gulp Starter on Rails | |||
# Blendid on Rails |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this section mention that it's probably a good idea to use webpacker instead of this, now that webpacker exists?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm keeping this PR narrowly focused on the word "gulp" and the "--
", but yes there's definitely room for future improvement
@@ -1,7 +1,7 @@ | |||
{ | |||
"name": "blendid", | |||
"version": "4.4.2", | |||
"description": "(formerly gulp-starter) A full featured configurable gulp asset pipeline and static site builder", | |||
"description": "A full featured configurable asset pipeline and static site builder", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious about the removal of gulp...it's still using gulp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This whole PR is picking up a decision the whole team landed on quite a while back. Idea is remove language that ties Blendid to any specific tech, so that the tool can evolve more easily. Back in the early gulp-starter days the word "Gulp" itself was a badge of using the hot newness; now what matters is the functionality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -3,7 +3,7 @@ | |||
[![Build Status](https://travis-ci.org/vigetlabs/blendid.svg?branch=static-server)](https://travis-ci.org/vigetlabs/blendid) | |||
[![Stories in Ready](https://badge.waffle.io/vigetlabs/blendid.png?label=ready&title=Ready)](https://waffle.io/vigetlabs/blendid) | |||
|
|||
**Blendid** is a delicious stand-alone blend of tasks and build tools combined to form a full-featured modern asset pipeline. It can be used as-is as a static site builder, or can be configured and integrated into your own development environment and site or app structure. | |||
**Blendid** is a delicious stand-alone blend of tasks and build tools poured together as a full-featured modern asset pipeline. It can be used as-is as a static site builder, or can be configured and integrated into your own development environment and site or app structure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
funny, looking at that diff I thought the whole reason I changed it was to remove a gulp reference :head-scratch: