Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Haswalt/ch17378/fork gqlgen and merge existing pr for allow #1

Merged
merged 3 commits into from
Feb 22, 2021
Merged

Haswalt/ch17378/fork gqlgen and merge existing pr for allow #1

merged 3 commits into from
Feb 22, 2021
+228 −5

Conversation

haswalt
Copy link

@haswalt haswalt commented Feb 18, 2021

@shortcut-integration
Copy link

This pull request has been linked to Clubhouse Story #17378: Fork gqlgen and merge existing PR for allow upgrade to latest version.

@haswalt
Copy link
Author

haswalt commented Feb 18, 2021

Only 1 test fails when running the suite which seems unrelated to these changes:

--- FAIL: TestAutobinding (1.38s)
    --- FAIL: TestAutobinding/with_file_path (0.14s)
        config_test.go:207: 
                Error Trace:    config_test.go:207
                Error:          An error is expected but got nil.
                Test:           TestAutobinding/with_file_path

@stevenjack
Copy link

@haswalt Does it fail if you just check out the public version without any of these changes?

@haswalt
Copy link
Author

haswalt commented Feb 22, 2021

It does, so i'm going to merge.

@haswalt haswalt merged commit 195ee89 into master Feb 22, 2021
@haswalt haswalt deleted the haswalt/ch17378/fork-gqlgen-and-merge-existing-pr-for-allow branch February 22, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenjack stevenjack stevenjack approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haswalt @stevenjack @ananyasaxena